Hi Andrea --
I think this is a great start. I have just a few comments which you
should interpret as "just one person's opinions"):
> For example, this is the stack trace produced by one of the tests I've
> created:
>
> Stacktrace
>
> halt (/Users/panzone/workspace/chapel/modules/internal/ChapelIO.chpl:679)
> fact (fact-stacktrace.chpl:1)
> fact (fact-stacktrace.chpl:1)
> fact (fact-stacktrace.chpl:1)
* For the procedure names, I might prefer them to be followed by
parens (if in fact they are procedures that take parens, or maybe
even if they don't), just to visually signal that they're routines.
I.e., imagine:
halt()
fact()
fact()
fact()
or:
halt(...)
fact(...)
fact(...)
fact(...)
(where the former has the advantage of brevity but might imply that
the procedures take no arguments; while the latter is needlessly
lengthier without adding much more useful information)
* w.r.t. the absolute path name, I have a vague sense that there is
other Chapel code that detects $CHPL_HOME as a prefix and removes
it, though I can't think where that is. Perhaps that code (or at
least approach) could be re-used here?
* I'm wrestling with whether or not it's useful to list halt() in
the stack trace given that all code will have that entry?
Best wishes,
-Brad
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
