Changeset: 504097576b7f for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=504097576b7f Modified Files: sql/ChangeLog.Jun2010 sql/src/backends/monet5/sql_gencode.mx Branch: Jun2010 Log Message:
fixed bug 2622 "LIMIT & OFFSET ignored on 64-bit big-endian when combined with GROUP BY" Indeed a 64-bit big-endian problem: OFFSET value is internally stored as type wrd, but sql/src/backends/monet5/sql_gencode.mx used to read from ival instead of wval diffs (23 lines): diff -r 650342fc1924 -r 504097576b7f sql/ChangeLog.Jun2010 --- a/sql/ChangeLog.Jun2010 Sun Jul 18 11:04:43 2010 +0200 +++ b/sql/ChangeLog.Jun2010 Sun Jul 18 16:17:19 2010 +0200 @@ -1,3 +1,7 @@ # ChangeLog file for sql # This file is updated with Maddlog +* Sun Jul 18 2010 Stefan Manegold <[email protected]> +- fixed bug 2622 "LIMIT & OFFSET ignored on 64-bit big-endian when + combined with GROUP BY" + diff -r 650342fc1924 -r 504097576b7f sql/src/backends/monet5/sql_gencode.mx --- a/sql/src/backends/monet5/sql_gencode.mx Sun Jul 18 11:04:43 2010 +0200 +++ b/sql/src/backends/monet5/sql_gencode.mx Sun Jul 18 16:17:19 2010 +0200 @@ -745,7 +745,7 @@ /* since both arguments of algebra.slice are inclusive correct the LIMIT value by substracting 1 */ - if (s->op2.stval->op1.aval->data.val.ival) { + if (s->op2.stval->op1.aval->data.val.wval) { q = newStmt1(mb, calcRef, "-"); q = pushArgument(mb, q, topn); q = pushInt(mb, q, 1); _______________________________________________ Checkin-list mailing list [email protected] http://mail.monetdb.org/mailman/listinfo/checkin-list
