Changeset: 07c16ed7cce4 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=07c16ed7cce4
Modified Files:
MonetDB/src/gdk/gdk_bbp.mx
Branch: Oct2010
Log Message:
Fix error from compiler.
MonetDB/src/gdk/gdk_bbp.mx:1853: error: "b" may be used uninitialized in this
function
The compiler was absolutely right, "b" could be used uninitialized,
and what's worse, indirected from uninitialized.
diffs (43 lines):
diff -r 18adf081a0ff -r 07c16ed7cce4 MonetDB/src/gdk/gdk_bbp.mx
--- a/MonetDB/src/gdk/gdk_bbp.mx Thu Oct 14 09:25:51 2010 +0200
+++ b/MonetDB/src/gdk/gdk_bbp.mx Thu Oct 14 09:27:32 2010 +0200
@@ -1912,13 +1912,13 @@
if (!bs->P.lview) {
b = getBBPdescriptor(hp, lock);
bs->B.H->heap.base = b->H->heap.base + (size_t)
bs->B.H->heap.base;
+ /* if we shared the hash before, share
+ it again note that if the parent's
+ hash is destroyed, we also don't
+ have a hash anymore */
+ if (bs->B.H->hash == (Hash *) -1)
+ bs->B.H->hash = b->H->hash;
}
- /* if we shared the hash before, share it again
- note that if the parent's hash is
- destroyed, we also don't have a hash
- anymore */
- if (bs->B.H->hash == (Hash *) -1)
- bs->B.H->hash = b->H->hash;
}
if (tp) {
incref(tp, 0, lock);
@@ -1926,13 +1926,13 @@
bs->B.H != bs->B.T) { /* mirror? */
b = getBBPdescriptor(tp, lock);
bs->B.T->heap.base = b->H->heap.base + (size_t)
bs->B.T->heap.base;
+ /* if we shared the hash before, share
+ it again note that if the parent's
+ hash is destroyed, we also don't
+ have a hash anymore */
+ if (bs->B.T->hash == (Hash *) -1)
+ bs->B.T->hash = b->H->hash;
}
- /* if we shared the hash before, share it again
- note that if the parent's hash is
- destroyed, we also don't have a hash
- anymore */
- if (bs->B.T->hash == (Hash *) -1)
- bs->B.T->hash = b->H->hash;
}
if (hvp)
incref(hvp, 0, lock);
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
