Changeset: ce6bcd9511d6 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=ce6bcd9511d6
Modified Files:
sql/src/backends/monet5/sql.mx
sql/src/backends/monet5/sql_gencode.mx
sql/src/backends/monet5/sql_scenario.mx
sql/src/server/rel_optimizer.mx
sql/src/server/rel_schema.mx
sql/src/server/rel_select.mx
sql/src/storage/store.mx
Branch: Oct2010
Log Message:
Minor Coverity updates
Coverity has been extended to detect superflous assignments.
They are generally not harmful.
diffs (truncated from 352 to 300 lines):
diff -r fef46302509f -r ce6bcd9511d6 sql/src/backends/monet5/sql.mx
--- a/sql/src/backends/monet5/sql.mx Mon Dec 27 11:49:00 2010 +0100
+++ b/sql/src/backends/monet5/sql.mx Tue Jan 04 17:20:48 2011 +0100
@@ -5240,7 +5240,7 @@
/* actually build the hash on the multi-column primary key */
- for (o = t->columns.set->h; o; o = o->next) {
+ for (o = t->columns.set->h; msg == MAL_SUCCEED && o; o = o->next) {
BAT *b, *e;
sql_delta *d;
sql_column *c = o->data;
@@ -5265,7 +5265,7 @@
t->cleared = 1;
t->base.wtime = s->base.wtime = tr->wtime = tr->stime;
t->base.rtime = s->base.rtime = tr->rtime = tr->stime;
- return MAL_SUCCEED;
+ return msg;
@c
str SQLnewDictionary(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci){
@:compression(DICTcompress(&ret, &nme, &b->batCacheid))@
@@ -5298,7 +5298,7 @@
/* actually build the hash on the multi-column primary key */
- for (o = t->columns.set->h; o; o = o->next) {
+ for (o = t->columns.set->h; msg == MAL_SUCCEED && o; o = o->next) {
BAT *b;
sql_column *c = o->data;
@@ -5311,7 +5311,7 @@
BBPreleaseref(b->batCacheid);
}
}
- return MAL_SUCCEED;
+ return msg;
@c
str SQLgzcompress(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci){
@:gzcompression(CMDbbpcompress(&ret, &b->batCacheid,&sbuf),gzcompress)@
diff -r fef46302509f -r ce6bcd9511d6 sql/src/backends/monet5/sql_gencode.mx
--- a/sql/src/backends/monet5/sql_gencode.mx Mon Dec 27 11:49:00 2010 +0100
+++ b/sql/src/backends/monet5/sql_gencode.mx Tue Jan 04 17:20:48 2011 +0100
@@ -168,7 +168,7 @@
q = pushStr(mb, q, t->type->sqlname);
q = pushInt(mb, q, t->digits);
q = pushInt(mb, q, t->scale);
- q = pushArgument(mb, q, c->nr);
+ (void) pushArgument(mb, q, c->nr);
if (tn != _empty)
_DELETE(tn);
if (sn != _empty)
@@ -187,7 +187,7 @@
InstrPtr k = newStmt1(mb, sqlRef, "declaredTable");
nr = getDestVar(k);
- k = pushStr(mb, k, t->base.name );
+ (void) pushStr(mb, k, t->base.name );
for (n = t->columns.set->h; n; n = n->next) {
sql_column *c = n->data;
char *tname = c->t->base.name;
@@ -200,7 +200,7 @@
q = pushStr(mb, q, cn);
q = pushStr(mb, q, c->type.type->sqlname);
q = pushInt(mb, q, c->type.digits);
- q = pushInt(mb, q, c->type.scale);
+ (void) pushInt(mb, q, c->type.scale);
_DELETE(tn);
}
return nr;
@@ -212,7 +212,7 @@
InstrPtr k = newStmt1(mb, sqlRef, "dropDeclaredTable");
int nr = getDestVar(k);
- k = pushStr(mb, k, n);
+ (void) pushStr(mb, k, n);
return nr;
}
@@ -542,7 +542,7 @@
setVarType(mb, getArg(q, 0), TYPE_int);
if (list_length(l) == 2) {
- q = pushStr(mb, q, (char *) n->next->data);
+ (void) pushStr(mb, q, (char *) n->next->data);
}
}
@@ -572,7 +572,7 @@
case st_none: {
q = newAssignment(mb);
s->nr = getDestVar(q);
- q = pushInt(mb, q, 1);
+ (void) pushInt(mb, q, 1);
} break;
case st_connection: {
if (list_length(s->op1.lval) < 3)
@@ -749,7 +749,7 @@
q = newStmt2(mb, batRef, appendRef);
q = pushArgument(mb, q, k);
- q = pushArgument(mb, q, l);
+ (void) pushArgument(mb, q, l);
l = k;
}
if (s->flag) {
@@ -1250,7 +1250,7 @@
snprintf(nme, SMALLBUFSIZ, "grp%d", getDestVar(q));
q = pushReturn(mb, q, newVariable(mb, nme, TYPE_any));
grp = getArg(q, 1);
- q = pushArgument(mb, q, o1);
+ (void) pushArgument(mb, q, o1);
q = newAssignment(mb);
q = pushArgument(mb, q, grp);
@@ -1288,7 +1288,7 @@
(void) snprintf(buf, SMALLBUFSIZ, "ext%d", g);
q = pushArgumentId(mb, q, buf);
q = pushArgument(mb, q, g);
- q = pushArgument(mb, q, l);
+ (void) pushArgument(mb, q, l);
q = newAssignment(mb);
q = pushArgument(mb, q, grp);
@@ -1314,7 +1314,7 @@
(void) snprintf(buf, SMALLBUFSIZ, "ext%d", g);
q = pushArgumentId(mb, q, buf);
q = pushArgument(mb, q, g);
- q = pushArgument(mb, q, l);
+ (void) pushArgument(mb, q, l);
q = newStmt2(mb, batRef, mirrorRef);
q = pushArgument(mb, q, e);
@@ -1793,7 +1793,7 @@
q = pushInt(mb, q, t->scale);
q = pushInt(mb, q, t->type->eclass);
q = pushArgument(mb, q, c->nr);
- q = pushStr(mb, q, ""); /* warning */
+ (void) pushStr(mb, q, ""); /* warning */
if (tn != _empty)
_DELETE(tn);
if (sn != _empty)
@@ -1825,7 +1825,7 @@
} else {
k = pushInt(mb, k, sql->mvc->type);
}
- k = pushArgument(mb, k, order->nr);
+ (void) pushArgument(mb, k, order->nr);
dump_header(mb, s, l);
if (s->type == st_export && s->op4.stval) {
@@ -1866,14 +1866,14 @@
*/
q = newStmt2(mb, sqlRef, exportResultRef);
q = pushArgument(mb, q, file);
- q = pushArgument(mb, q, s->nr);
+ (void) pushArgument(mb, q, s->nr);
if (s->type == st_export && s->op4.stval) {
q = newStmt(mb, "streams", "close");
- q = pushArgument(mb, q, file);
+ (void) pushArgument(mb, q, file);
}
} else {
q = newStmt1(mb, sqlRef, "print");
- q = pushStr(mb, q, "not a valid output list\n");
+ (void) pushStr(mb, q, "not a valid output
list\n");
}
}
break;
@@ -1889,11 +1889,11 @@
q = newStmt1(mb, batRef, "new");
s->nr = getDestVar(q);
q = pushType(mb, q, TYPE_str);
- q = pushType(mb, q, TYPE_bat);
+ (void) pushType(mb, q, TYPE_bat);
s->nr = dump_cols(mb, l, s->nr);
} else {
q = newStmt1(mb, sqlRef, "print");
- q = pushStr(mb, q, "not a valid output list\n");
+ (void) pushStr(mb, q, "not a valid output
list\n");
}
}
break;
@@ -1907,7 +1907,7 @@
q = newAssignment(mb);
q->barrier= BARRIERsymbol;
bvar = getArg(q,0);
- q = pushBit(mb, q, TRUE);
+ (void) pushBit(mb, q, TRUE);
/* leave barrier */
c = _dumpstmt(sql,mb, s->op1.stval);
@@ -1927,7 +1927,7 @@
q->barrier= REDOsymbol;
getArg(q,0) = bvar;
q->argc = q->retc = 1;
- q = pushBit(mb, q, TRUE);
+ (void) pushBit(mb, q, TRUE);
/* exit barrier */
q = newAssignment(mb);
@@ -1970,7 +1970,7 @@
if (s->flag) { /* drop declared tables */
InstrPtr k = newStmt1(mb, sqlRef,
"dropDeclaredTables");
- k = pushInt(mb, k, s->flag);
+ (void) pushInt(mb, k, s->flag);
}
q = newInstruction(mb,RETURNsymbol);
getArg(q,0) = getArg(getInstrPtr(mb,0),0);
@@ -2004,7 +2004,7 @@
q = newStmt1(mb, sqlRef, "setVariable");
q = pushArgument(mb, q, vn);
}
- q = pushArgument(mb, q, r);
+ (void) pushArgument(mb, q, r);
} break;
/* todo */
@@ -2056,7 +2056,7 @@
be->mvc_var = old_mv;
if (c->caching && (c->type == Q_SCHEMA || c->type == Q_TRANS)) {
q = newStmt2(mb, sqlRef, exportOperationRef);
- q = pushStr(mb, q, ""); /* warning */
+ (void) pushStr(mb, q, ""); /* warning */
}
/* generate a dummy return assignment for functions */
if (getArgType(mb,getInstrPtr(mb,0),0) != TYPE_void &&
@@ -2095,10 +2095,10 @@
if (atom_null(a)) {
sql_subtype *t = atom_type(a);
- curInstr = pushNil(curBlk, curInstr,
t->type->localtype);
+ (void) pushNil(curBlk, curInstr,
t->type->localtype);
} else {
int _t = constantAtom(be, curBlk, a);
- curInstr = pushArgument(curBlk, curInstr, _t);
+ (void) pushArgument(curBlk, curInstr, _t);
}
}
}
@@ -2194,7 +2194,7 @@
q = pushWrd(mb, q, queryid);
q = pushStr(mb, q, t);
q = pushLng(mb, q, m->Tparse );
- q = pushLng(mb, q, Toptimize);
+ (void) pushLng(mb, q, Toptimize);
m->Tparse = 0;
}
if (cq)
diff -r fef46302509f -r ce6bcd9511d6 sql/src/backends/monet5/sql_scenario.mx
--- a/sql/src/backends/monet5/sql_scenario.mx Mon Dec 27 11:49:00 2010 +0100
+++ b/sql/src/backends/monet5/sql_scenario.mx Tue Jan 04 17:20:48 2011 +0100
@@ -1047,13 +1047,13 @@
if (onoff){
if ( strstr(def,"keep") == 0)
- q = newStmt(mb,"profiler","reset");
+ (void) newStmt(mb,"profiler","reset");
q = newStmt(mb,"profiler","setFilter");
q = pushStr(mb,q, "*");
q = pushStr(mb,q, "*");
- q = newStmt(mb,"profiler","start");
+ (void) newStmt(mb,"profiler","start");
} else if (def && strstr(def, "show")) {
- q = newStmt(mb, "profiler", "stop");
+ (void) newStmt(mb, "profiler", "stop");
do {
s = t;
@@ -1119,14 +1119,14 @@
q = pushInt(mb, q, 32);
}
q = pushInt(mb, q, 0);
- q = pushArgument(mb, q, rs[j]);
+ (void) pushArgument(mb, q, rs[j]);
}
q = newStmt(mb, ioRef, "stdout");
n = getDestVar(q);
q = newStmt(mb, sqlRef, "exportResult");
q = pushArgument(mb, q, n);
- q = pushArgument(mb, q, r);
+ (void) pushArgument(mb, q, r);
}
}
GDKfree(def);
diff -r fef46302509f -r ce6bcd9511d6 sql/src/server/rel_optimizer.mx
--- a/sql/src/server/rel_optimizer.mx Mon Dec 27 11:49:00 2010 +0100
+++ b/sql/src/server/rel_optimizer.mx Tue Jan 04 17:20:48 2011 +0100
@@ -90,7 +90,7 @@
}
case op_table:
if (rel->exps)
- alias = exps_bind_column(rel->exps, name, NULL);
+ (void) exps_bind_column(rel->exps, name, NULL);
/* table func */
return NULL;
case op_join:
diff -r fef46302509f -r ce6bcd9511d6 sql/src/server/rel_schema.mx
--- a/sql/src/server/rel_schema.mx Mon Dec 27 11:49:00 2010 +0100
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
