Changeset: 168f15887717 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=168f15887717
Modified Files:
clients/odbc/samples/Makefile.ag
Branch: Mar2011
Log Message:
odbc: don't build incorrect sample
Modules cannot be linked against, but only dlopened on some platforms
(like Darwin). The example here isn't right, as it should have linked
against (unix)ODBC and load the MonetDB driver through its
drivermanager, which correctly does dlopen.
We should fix this, and figure out how to do this correctly also in
combination with testing.
diffs (26 lines):
diff --git a/clients/odbc/samples/Makefile.ag b/clients/odbc/samples/Makefile.ag
--- a/clients/odbc/samples/Makefile.ag
+++ b/clients/odbc/samples/Makefile.ag
@@ -17,12 +17,16 @@
MTSAFE
-BINS = {
- CONDINST = HAVE_TESTING
- DIR = libdir/monetdb/tests
- SOURCES = odbcsample1.c testgetinfo.c
- LIBS = ../driver/libMonetODBC ../../mapilib/libmapi $(curl_LIBS)
-}
+# FIXME: libMonetODBC is actually a module, once cannot link against
+# that on Darwin. We need to properly link against (unix)ODBC and use
+# it's drivermanager which correctly dlopens the MonetODBC module. This
+# requires a odbc.ini file, and testing to be aware of it as well.
+#BINS = {
+# CONDINST = HAVE_TESTING
+# DIR = libdir/monetdb/tests
+# SOURCES = odbcsample1.c testgetinfo.c
+# LIBS = ../driver/libMonetODBC ../../mapilib/libmapi $(curl_LIBS)
+#}
bin_odbctest = {
COND = NATIVE_WIN32
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
