I've seen you make a change like this before. We had the rule that the inclusion of the config.h file should be the first thing in a source (i.e. .c) file. Are you abandoning that rule?
On 2011-02-28 23:10, Fabian Groffen wrote: > Changeset: 4ef92ddae9aa for MonetDB > URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=4ef92ddae9aa > Modified Files: > gdk/gdk.mx > Branch: Mar2011 > Log Message: > > gdk.h: include monetdb_config.h before using HAVE_XXX guards > > It works better when defines are actually set, in particular on Solaris. > This solves the implicit madvise there, and probably also the sbrk > problem with Intel compiler on x86_64-linux. > > > diffs (11 lines): > > diff --git a/gdk/gdk.mx b/gdk/gdk.mx > --- a/gdk/gdk.mx > +++ b/gdk/gdk.mx > @@ -317,6 +317,7 @@ > #ifndef _GDK_H_ > #define _GDK_H_ > > +#include "monetdb_config.h" > /* standard includes upon which all configure tests depend */ > #include <stdio.h> > #ifdef HAVE_SYS_TYPES_H > _______________________________________________ > Checkin-list mailing list > [email protected] > http://mail.monetdb.org/mailman/listinfo/checkin-list -- Sjoerd Mullender
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Checkin-list mailing list [email protected] http://mail.monetdb.org/mailman/listinfo/checkin-list
