Changeset: 9c38c742a77f for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=9c38c742a77f
Modified Files:
gdk/gdk_atoms.mx
gdk/gdk_bat.mx
gdk/gdk_delta.mx
gdk/gdk_logger.mx
gdk/gdk_rangejoin.mx
gdk/gdk_scanselect.mx
gdk/gdk_search.mx
gdk/gdk_setop.mx
gdk/gdk_storage.mx
gdk/gdk_tm.mx
monetdb5/mal/mal.mx
monetdb5/modules/kernel/logger.mx
monetdb5/modules/mal/pma.mx
monetdb5/modules/mal/tablet.mx
monetdb5/modules/mal/tablet_sql.mx
Branch: Apr2011
Log Message:
Cleanup: don't do unnecessary includes of gdk.h (and some others).
Within gdk, we only include gdk.h in the .c file, never in a .h file.
gdk.h itself includes most of the other .h files in gdk (not all!) so
we don't need to include those if we already included gdk.h.
diffs (192 lines):
diff --git a/gdk/gdk_atoms.mx b/gdk/gdk_atoms.mx
--- a/gdk/gdk_atoms.mx
+++ b/gdk/gdk_atoms.mx
@@ -31,7 +31,6 @@
@h
#ifndef _GDK_ATOMS_H_
#define _GDK_ATOMS_H_
-#include "gdk.h"
#define MAXATOMS 128
diff --git a/gdk/gdk_bat.mx b/gdk/gdk_bat.mx
--- a/gdk/gdk_bat.mx
+++ b/gdk/gdk_bat.mx
@@ -54,8 +54,6 @@
#ifndef _GDK_BAT_H_
#define _GDK_BAT_H_
-#include "gdk.h"
-
gdk_export void BATinit_idents(BAT *bn);
gdk_export BUN void_replace_bat(BAT *b, BAT *u, bit force);
gdk_export int void_inplace(BAT *b, oid id, ptr val, bit force);
diff --git a/gdk/gdk_delta.mx b/gdk/gdk_delta.mx
--- a/gdk/gdk_delta.mx
+++ b/gdk/gdk_delta.mx
@@ -33,7 +33,6 @@
@h
#ifndef _GDK_DELTA_H_
#define _GDK_DELTA_H_
-#include "gdk.h"
@-
We make sure here that the BUNs section of a BAT at least starts
diff --git a/gdk/gdk_logger.mx b/gdk/gdk_logger.mx
--- a/gdk/gdk_logger.mx
+++ b/gdk/gdk_logger.mx
@@ -73,8 +73,6 @@
#define LOG_OK 0
#define LOG_ERR (-1)
-#include <gdk.h>
-
typedef struct logaction {
int type; /* type of change */
int nr;
@@ -173,6 +171,7 @@
#endif /*_LOGGER_H_*/
@c
#include "monetdb_config.h"
+#include "gdk.h"
#include "gdk_logger.h"
#include <string.h>
diff --git a/gdk/gdk_rangejoin.mx b/gdk/gdk_rangejoin.mx
--- a/gdk/gdk_rangejoin.mx
+++ b/gdk/gdk_rangejoin.mx
@@ -29,8 +29,6 @@
#ifndef GDK_RANGEJOIN_H
#define GDK_RANGEJOIN_H
-#include "gdk.h"
-
@- BAT range and band join operators
The @%BATbandjoin@ produces the associations [A, D] such that S.C-c1 <=
R.b <= S.C + c2. The special case c1 = 0 and c2 = infinite leads to a
@@ -57,6 +55,7 @@
@c
#include "monetdb_config.h"
+#include "gdk.h"
#include "gdk_rangejoin.h"
@{
diff --git a/gdk/gdk_scanselect.mx b/gdk/gdk_scanselect.mx
--- a/gdk/gdk_scanselect.mx
+++ b/gdk/gdk_scanselect.mx
@@ -102,7 +102,6 @@
@h
#ifndef _GDK_SCANSELECT_H
#define _GDK_SCANSELECT_H
-#include "gdk.h"
@- "Tools"
First, we need some tools. These are the type-expanded replacements
diff --git a/gdk/gdk_search.mx b/gdk/gdk_search.mx
--- a/gdk/gdk_search.mx
+++ b/gdk/gdk_search.mx
@@ -67,7 +67,6 @@
@h
#ifndef _GDK_SEARCH_H_
#define _GDK_SEARCH_H_
-#include "gdk.h"
@}
@+ Hash indexing
This is a highly efficient implementation of simple bucket-chained hashing.
diff --git a/gdk/gdk_setop.mx b/gdk/gdk_setop.mx
--- a/gdk/gdk_setop.mx
+++ b/gdk/gdk_setop.mx
@@ -61,7 +61,6 @@
@h
#ifndef _GDK_SETOP_H
#define _GDK_SETOP_H
-#include "gdk.h"
#define HITk(t1,t2) TRUE
#define HITs(t1,t2) ((*cmp)(t1,t2) == 0)
diff --git a/gdk/gdk_storage.mx b/gdk/gdk_storage.mx
--- a/gdk/gdk_storage.mx
+++ b/gdk/gdk_storage.mx
@@ -38,7 +38,6 @@
@h
#ifndef _GDK_STORAGE_H_
#define _GDK_STORAGE_H_
-#include "gdk.h"
extern void DESCclean(BAT *);
extern int DESCsetmodes(BAT *b);
diff --git a/gdk/gdk_tm.mx b/gdk/gdk_tm.mx
--- a/gdk/gdk_tm.mx
+++ b/gdk/gdk_tm.mx
@@ -29,7 +29,6 @@
@h
#ifndef _GDK_TM_H_
#define _GDK_TM_H_
-#include "gdk.h"
#define SYSTRANSACTION "tmp"
#define MAXTM 10
diff --git a/monetdb5/mal/mal.mx b/monetdb5/mal/mal.mx
--- a/monetdb5/mal/mal.mx
+++ b/monetdb5/mal/mal.mx
@@ -180,7 +180,6 @@
#define _MAL_H
#include <gdk.h>
-#include <gdk_utils.h>
#ifdef WIN32
#if !defined(LIBMAL) && !defined(LIBATOMS) && !defined(LIBKERNEL) &&
!defined(LIBMAL) && !defined(LIBOPTIMIZER) && !defined(LIBSCHEDULER) &&
!defined(LIBMONETDB5)
diff --git a/monetdb5/modules/kernel/logger.mx
b/monetdb5/modules/kernel/logger.mx
--- a/monetdb5/modules/kernel/logger.mx
+++ b/monetdb5/modules/kernel/logger.mx
@@ -80,6 +80,7 @@
@+ Implementation Code
@c
#include "monetdb_config.h"
+#include "gdk.h"
#include "gdk_logger.h"
#include "mal.h"
#include "mal_exception.h"
diff --git a/monetdb5/modules/mal/pma.mx b/monetdb5/modules/mal/pma.mx
--- a/monetdb5/modules/mal/pma.mx
+++ b/monetdb5/modules/mal/pma.mx
@@ -94,7 +94,6 @@
#endif
#include <gdk.h>
-#include <gdk_atoms.h>
pma_export str PMAnew_wrd(bat *res, int *tpe, wrd *sz);
@= pma_decl
pma_export str PMAins_@1(oid *pos_res, bat *b, oid *pos, @1 *val);
@@ -119,7 +118,6 @@
@c
#include "monetdb_config.h"
#include "mal_exception.h"
-#include <gdk_utils.h>
#include "pma.h"
#include <math.h>
diff --git a/monetdb5/modules/mal/tablet.mx b/monetdb5/modules/mal/tablet.mx
--- a/monetdb5/modules/mal/tablet.mx
+++ b/monetdb5/modules/mal/tablet.mx
@@ -504,7 +504,6 @@
#include <string.h>
#include <ctype.h>
-#include <gdk_posix.h>
#define CLEAR(X) if(X) {GDKfree(X);X = NULL;}
#define isScalar(C) C->adt != TYPE_bat
diff --git a/monetdb5/modules/mal/tablet_sql.mx
b/monetdb5/modules/mal/tablet_sql.mx
--- a/monetdb5/modules/mal/tablet_sql.mx
+++ b/monetdb5/modules/mal/tablet_sql.mx
@@ -51,7 +51,6 @@
#include <string.h>
#include <ctype.h>
-#include <gdk_posix.h>
/* #define _DEBUG_TABLET_*/
/* #define MLOCK_TST did not make a difference on sf10 */
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
