Changeset: d4917e9dde9f for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=d4917e9dde9f
Modified Files:
monetdb5/mal/mal_interpreter.mx
Branch: default
Log Message:
Admission control dropped
Controlling the number of instructions based on their memory footprint
appear not to produce significant improvement. Aside from proper calculation
of what is in memory (we don't know), admission would reduce the impact
of concurrent actions. In de SF-10 and SF-100 cases this has not been
measurably observed. The code is put to sleep until better insight
and ideas appear.
diffs (38 lines):
diff --git a/monetdb5/mal/mal_interpreter.mx b/monetdb5/mal/mal_interpreter.mx
--- a/monetdb5/mal/mal_interpreter.mx
+++ b/monetdb5/mal/mal_interpreter.mx
@@ -79,6 +79,7 @@
#define MEMORY_THRESHOLD 0.8
#ifdef USE_DFLOW_ADMISSION
+/* does not seem to have a major impact */
static lng memorypool; /* memory claimed by concurrent threads */
static int memoryclaims = 0; /* number of threads active with expensive
operations */
#endif
@@ -709,7 +710,6 @@
*/
#ifdef USE_DFLOW_ADMISSION
/* experiments on sf-100 on small machine showed no real improvement
- Q10 became even 3x slower.
*/
int
DFLOWadmission(lng argclaim, lng hotclaim)
@@ -1053,7 +1053,7 @@
#ifdef USE_DFLOW_ADMISSION
if (DFLOWadmission(fs->argclaim, fs->hotclaim)) {
fs->hotclaim = 0; /* don't assume priority anymore */
- MT_sleep_ms(fs->argclaim / 1000000);
+ MT_sleep_ms(1);
q_requeue(task->todo, fs);
nxtfs = 0;
continue;
@@ -1200,6 +1200,9 @@
}
mnstr_printf(GDKstdout, "\n");
}
+#ifdef USE_DFLOW_ADMISSION
+ memorypool = memoryclaims = 0;
+#endif
}
@-
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
