On 04-08-2011 16:22:10 +0200, Sjoerd Mullender wrote:
> > -                                   char *fqtn = alloca(sizeof(char) * 
> > (strlen(nsn) + 1 +
> > -                                                           strlen(ntn) + 
> > 1));
> > +                                   char fqtn[512];
> >  
> > -                                   fqtn[0]=0;
> > -                                   strcat(fqtn, nsn);
> > -                                   strcat(fqtn, ".");
> > -                                   strcat(fqtn, ntn);
> > +                                   snprintf(fqtn, 512, "%s.%s", nsn, ntn);
> 
> I would use sizeof(fqtn) here so that you only need to change the value
> once (when you change it).

I did this for initial consistency.  I think a better fix is necessary.
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list

Reply via email to