Changeset: a5bb05b293b7 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=a5bb05b293b7
Added Files:
sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.sql
sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.err
sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.out
Modified Files:
sql/server/rel_optimizer.c
sql/test/BugTracker-2012/Tests/All
Branch: Apr2012
Log Message:
fixed bug in push function down (from select or join) with predicates
diffs (266 lines):
diff --git a/sql/server/rel_optimizer.c b/sql/server/rel_optimizer.c
--- a/sql/server/rel_optimizer.c
+++ b/sql/server/rel_optimizer.c
@@ -1357,40 +1357,26 @@ rel_push_func_down(int *changes, mvc *sq
sql_exp *e = n->data, *ne = NULL;
int must = 0, mustl = 0, mustr = 0;
- assert(e->type == e_cmp);
+ if (e->type == e_column)
+ continue;
if ((is_join(rel->op) && ((can_push_func(e, l,
&mustl) && mustl) || (can_push_func(e, r, &mustr) && mustr))) ||
(is_select(rel->op) && can_push_func(e,
NULL, &must) && must)) {
must = 0; mustl = 0; mustr = 0;
- ne = e->l;
- if ((is_join(rel->op) &&
((can_push_func(ne, l, &mustl) && mustl) || (can_push_func(ne, r, &mustr) &&
mustr))) ||
- (is_select(rel->op) &&
can_push_func(ne, NULL, &must) && must)) {
- exp_label(sql->sa, ne,
++sql->label);
- if (mustr)
- append(r->exps, ne);
- else
- append(l->exps, ne);
- ne = exp_column(sql->sa,
exp_relname(ne), exp_name(ne), exp_subtype(ne), ne->card, has_nil(ne),
is_intern(ne));
- }
- e->l = ne;
-
- must = 0; mustl = 0; mustr = 0;
- ne = e->r;
- if ((is_join(rel->op) &&
((can_push_func(ne, l, &mustl) && mustl) || (can_push_func(ne, r, &mustr) &&
mustr))) ||
- (is_select(rel->op) &&
can_push_func(ne, NULL, &must) && must)) {
- exp_label(sql->sa, ne,
++sql->label);
- if (mustr)
- append(r->exps, ne);
- else
- append(l->exps, ne);
- ne = exp_column(sql->sa,
exp_relname(ne), exp_name(ne), exp_subtype(ne), ne->card, has_nil(ne),
is_intern(ne));
- }
- e->r = ne;
-
- if (e->f) {
- must = 0; mustl = 0; mustr = 0;
- ne = e->f;
+ if (e->type != e_cmp) { /* predicate */
+ if ((is_join(rel->op) &&
((can_push_func(e, l, &mustl) && mustl) || (can_push_func(e, r, &mustr) &&
mustr))) ||
+ (is_select(rel->op) &&
can_push_func(e, NULL, &must) && must)) {
+ exp_label(sql->sa, e,
++sql->label);
+ if (mustr)
+ append(r->exps,
e);
+ else
+ append(l->exps,
e);
+ e = exp_column(sql->sa,
exp_relname(e), exp_name(e), exp_subtype(e), e->card, has_nil(e), is_intern(e));
+ n->data = e;
+ }
+ } else {
+ ne = e->l;
if ((is_join(rel->op) &&
((can_push_func(ne, l, &mustl) && mustl) || (can_push_func(ne, r, &mustr) &&
mustr))) ||
- (is_select(rel->op) &&
can_push_func(ne, NULL, &must) && must)) {
+ (is_select(rel->op) &&
can_push_func(ne, NULL, &must) && must)) {
exp_label(sql->sa, ne,
++sql->label);
if (mustr)
append(r->exps,
ne);
@@ -1398,11 +1384,39 @@ rel_push_func_down(int *changes, mvc *sq
append(l->exps,
ne);
ne =
exp_column(sql->sa, exp_relname(ne), exp_name(ne), exp_subtype(ne), ne->card,
has_nil(ne), is_intern(ne));
}
- e->f = ne;
+ e->l = ne;
+
+ must = 0; mustl = 0; mustr = 0;
+ ne = e->r;
+ if ((is_join(rel->op) &&
((can_push_func(ne, l, &mustl) && mustl) || (can_push_func(ne, r, &mustr) &&
mustr))) ||
+ (is_select(rel->op) &&
can_push_func(ne, NULL, &must) && must)) {
+ exp_label(sql->sa, ne,
++sql->label);
+ if (mustr)
+ append(r->exps,
ne);
+ else
+ append(l->exps,
ne);
+ ne =
exp_column(sql->sa, exp_relname(ne), exp_name(ne), exp_subtype(ne), ne->card,
has_nil(ne), is_intern(ne));
+ }
+ e->r = ne;
+
+ if (e->f) {
+ must = 0; mustl = 0;
mustr = 0;
+ ne = e->f;
+ if ((is_join(rel->op)
&& ((can_push_func(ne, l, &mustl) && mustl) || (can_push_func(ne, r, &mustr) &&
mustr))) ||
+ (is_select(rel->op)
&& can_push_func(ne, NULL, &must) && must)) {
+
exp_label(sql->sa, ne, ++sql->label);
+ if (mustr)
+
append(r->exps, ne);
+ else
+
append(l->exps, ne);
+ ne =
exp_column(sql->sa, exp_relname(ne), exp_name(ne), exp_subtype(ne), ne->card,
has_nil(ne), is_intern(ne));
+ }
+ e->f = ne;
+ }
}
+ (*changes)++;
}
}
- (*changes)++;
}
}
if (rel->op == op_project && rel->l && rel->exps) {
diff --git a/sql/test/BugTracker-2012/Tests/All
b/sql/test/BugTracker-2012/Tests/All
--- a/sql/test/BugTracker-2012/Tests/All
+++ b/sql/test/BugTracker-2012/Tests/All
@@ -39,3 +39,4 @@ bug_large-insert-Bug.2960
any_null.Bug-2594
float-mod.Bug-3086
aggregate_vs_positional_column_crash.Bug-3085
+predicate_select.Bug-3090
diff --git a/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.sql
b/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.sql
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.sql
@@ -0,0 +1,2 @@
+select * from tables where 1;
+select * from tables where name;
diff --git
a/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.err
b/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.err
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.err
@@ -0,0 +1,37 @@
+stderr of test 'predicate_select.Bug-3090` in directory 'test/BugTracker-2012`
itself:
+
+
+# 18:53:13 >
+# 18:53:13 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"gdk_dbfarm=/home/niels/scratch/rc-clean/Linux-x86_64/var/MonetDB" "--set"
"mapi_open=true" "--set" "mapi_port=32323" "--set" "monet_prompt=" "--trace"
"--forcemito" "--set" "mal_listing=2" "--dbname=mTests_test_BugTracker-2012"
"--set" "mal_listing=0"
+# 18:53:13 >
+
+# builtin opt gdk_dbname = demo
+# builtin opt gdk_dbfarm =
/home/niels/scratch/rc-clean/Linux-x86_64/var/monetdb5/dbfarm
+# builtin opt gdk_debug = 0
+# builtin opt gdk_alloc_map = no
+# builtin opt gdk_vmtrim = yes
+# builtin opt monet_prompt = >
+# builtin opt monet_daemon = no
+# builtin opt mapi_port = 50000
+# builtin opt mapi_open = false
+# builtin opt mapi_autosense = false
+# builtin opt sql_optimizer = default_pipe
+# builtin opt sql_debug = 0
+# cmdline opt gdk_nr_threads = 0
+# cmdline opt gdk_dbfarm =
/home/niels/scratch/rc-clean/Linux-x86_64/var/MonetDB
+# cmdline opt mapi_open = true
+# cmdline opt mapi_port = 32323
+# cmdline opt monet_prompt =
+# cmdline opt mal_listing = 2
+# cmdline opt gdk_dbname = mTests_test_BugTracker-2012
+# cmdline opt mal_listing = 0
+
+# 18:53:13 >
+# 18:53:13 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e" "--host=niels"
"--port=32323"
+# 18:53:13 >
+
+
+# 18:53:13 >
+# 18:53:13 > "Done."
+# 18:53:13 >
+
diff --git
a/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.out
b/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.out
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2012/Tests/predicate_select.Bug-3090.stable.out
@@ -0,0 +1,102 @@
+stdout of test 'predicate_select.Bug-3090` in directory 'test/BugTracker-2012`
itself:
+
+
+# 18:53:13 >
+# 18:53:13 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"gdk_dbfarm=/home/niels/scratch/rc-clean/Linux-x86_64/var/MonetDB" "--set"
"mapi_open=true" "--set" "mapi_port=32323" "--set" "monet_prompt=" "--trace"
"--forcemito" "--set" "mal_listing=2" "--dbname=mTests_test_BugTracker-2012"
"--set" "mal_listing=0"
+# 18:53:13 >
+
+# MonetDB 5 server v11.9.2
+# This is an unreleased version
+# Serving database 'mTests_test_BugTracker-2012', using 4 threads
+# Compiled for x86_64-unknown-linux-gnu/64bit with 64bit OIDs dynamically
linked
+# Found 3.778 GiB available main-memory.
+# Copyright (c) 1993-July 2008 CWI.
+# Copyright (c) August 2008-2012 MonetDB B.V., all rights reserved
+# Visit http://www.monetdb.org/ for further information
+# Listening for connection requests on
mapi:monetdb://niels.nesco.mine.nu:32323/
+# MonetDB/GIS module loaded
+# MonetDB/SQL module loaded
+
+Ready.
+
+# 18:53:13 >
+# 18:53:13 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e" "--host=niels"
"--port=32323"
+# 18:53:13 >
+
+#select * from tables where 1;
+% .tables, .tables, .tables, .tables, .tables,
.tables, .tables, .tables, .tables # table_name
+% id, name, schema_id, query, type, system, commit_action,
readonly, temporary # name
+% int, varchar, int, varchar, smallint, boolean,
smallint, boolean, tinyint # type
+% 4, 15, 4, 192, 1, 5, 1, 5, 1 # length
+[ 2001, "schemas", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2006, "types", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2015, "functions", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2024, "args", 2000, NULL, 0, true, 0, false, 0
]
+[ 2032, "sequences", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2042, "dependencies", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2046, "connections", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2055, "_tables", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2064, "_columns", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2075, "keys", 2000, NULL, 0, true, 0, false, 0
]
+[ 2082, "idxs", 2000, NULL, 0, true, 0, false, 0
]
+[ 2087, "triggers", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2098, "objects", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2103, "_tables", 2102, NULL, 0, true, 2, false,
0 ]
+[ 2112, "_columns", 2102, NULL, 0, true, 2, false,
0 ]
+[ 2123, "keys", 2102, NULL, 0, true, 2, false, 0
]
+[ 2130, "idxs", 2102, NULL, 0, true, 2, false, 0
]
+[ 2135, "triggers", 2102, NULL, 0, true, 2, false,
0 ]
+[ 2146, "objects", 2102, NULL, 0, true, 2, false,
0 ]
+[ 4993, "tables", 2000, "SELECT * FROM (SELECT p.*, 0 AS
\"temporary\" FROM \"sys\".\"_tables\" AS p UNION ALL SELECT t.*, 1 AS
\"temporary\" FROM \"tmp\".\"_tables\" AS t) AS tables where tables.type < 2;",
1, true, 0, false, 0 ]
+[ 5003, "columns", 2000, "SELECT * FROM (SELECT p.* FROM
\"sys\".\"_columns\" AS p UNION ALL SELECT t.* FROM \"tmp\".\"_columns\" AS t)
AS columns;", 1, true, 0, false, 0 ]
+[ 5023, "db_user_info", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5031, "users", 2000, "SELECT u.\"name\" AS \"name\",
ui.\"fullname\", ui.\"default_schema\" FROM db_users() AS u LEFT JOIN
\"sys\".\"db_user_info\" AS ui ON u.\"name\" = ui.\"name\" ;", 1, true,
0, false, 0 ]
+[ 5035, "user_role", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5038, "auths", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5042, "privileges", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5195, "queryhistory", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5209, "callhistory", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5226, "querylog", 2000, "create view querylog as\nselect qd.*,
ql.ctime, ql.arguments, ql.exec, ql.result, ql.foot, ql.memory, ql.tuples,
ql.inblock, ql.oublock from queryhistory qd, callhistory ql\nwhere qd.id =
ql.id;", 1, true, 0, false, 0 ]
+[ 5824, "systemfunctions", 2000, NULL, 0, true, 0,
false, 0 ]
+[ 5930, "r", 2000, NULL, 0, false, 0, false, 0
]
+#select * from tables where name;
+% .tables, .tables, .tables, .tables, .tables,
.tables, .tables, .tables, .tables # table_name
+% id, name, schema_id, query, type, system, commit_action,
readonly, temporary # name
+% int, varchar, int, varchar, smallint, boolean,
smallint, boolean, tinyint # type
+% 4, 15, 4, 192, 1, 5, 1, 5, 1 # length
+[ 2001, "schemas", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2006, "types", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2015, "functions", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2024, "args", 2000, NULL, 0, true, 0, false, 0
]
+[ 2032, "sequences", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2042, "dependencies", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2046, "connections", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2055, "_tables", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2064, "_columns", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2075, "keys", 2000, NULL, 0, true, 0, false, 0
]
+[ 2082, "idxs", 2000, NULL, 0, true, 0, false, 0
]
+[ 2087, "triggers", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2098, "objects", 2000, NULL, 0, true, 0, false,
0 ]
+[ 2103, "_tables", 2102, NULL, 0, true, 2, false,
0 ]
+[ 2112, "_columns", 2102, NULL, 0, true, 2, false,
0 ]
+[ 2123, "keys", 2102, NULL, 0, true, 2, false, 0
]
+[ 2130, "idxs", 2102, NULL, 0, true, 2, false, 0
]
+[ 2135, "triggers", 2102, NULL, 0, true, 2, false,
0 ]
+[ 2146, "objects", 2102, NULL, 0, true, 2, false,
0 ]
+[ 4993, "tables", 2000, "SELECT * FROM (SELECT p.*, 0 AS
\"temporary\" FROM \"sys\".\"_tables\" AS p UNION ALL SELECT t.*, 1 AS
\"temporary\" FROM \"tmp\".\"_tables\" AS t) AS tables where tables.type < 2;",
1, true, 0, false, 0 ]
+[ 5003, "columns", 2000, "SELECT * FROM (SELECT p.* FROM
\"sys\".\"_columns\" AS p UNION ALL SELECT t.* FROM \"tmp\".\"_columns\" AS t)
AS columns;", 1, true, 0, false, 0 ]
+[ 5023, "db_user_info", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5031, "users", 2000, "SELECT u.\"name\" AS \"name\",
ui.\"fullname\", ui.\"default_schema\" FROM db_users() AS u LEFT JOIN
\"sys\".\"db_user_info\" AS ui ON u.\"name\" = ui.\"name\" ;", 1, true,
0, false, 0 ]
+[ 5035, "user_role", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5038, "auths", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5042, "privileges", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5195, "queryhistory", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5209, "callhistory", 2000, NULL, 0, true, 0, false,
0 ]
+[ 5226, "querylog", 2000, "create view querylog as\nselect qd.*,
ql.ctime, ql.arguments, ql.exec, ql.result, ql.foot, ql.memory, ql.tuples,
ql.inblock, ql.oublock from queryhistory qd, callhistory ql\nwhere qd.id =
ql.id;", 1, true, 0, false, 0 ]
+[ 5824, "systemfunctions", 2000, NULL, 0, true, 0,
false, 0 ]
+[ 5930, "r", 2000, NULL, 0, false, 0, false, 0
]
+
+# 18:53:13 >
+# 18:53:13 > "Done."
+# 18:53:13 >
+
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
