MonetDB: Jul2012 - Don't assign to variable to then immediately ...

[Sjoerd Mullender]

Changeset: dcf4093062e8 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=dcf4093062e8
Modified Files:
        sql/server/rel_select.c
Branch: Jul2012
Log Message:

Don't assign to variable to then immediately overwrite the variable again.
Found by coverity.


diffs (12 lines):

diff --git a/sql/server/rel_select.c b/sql/server/rel_select.c
--- a/sql/server/rel_select.c
+++ b/sql/server/rel_select.c
@@ -4807,7 +4807,7 @@ rel_select_exp(mvc *sql, sql_rel *rel, s
                                        if (!is_project(outer->op))
                                                rel->l = outer = 
rel_project(sql->sa, outer, rel_projections(sql, outer, NULL, 1, 1));
                                        /* find or create identity column */
-                                       if ((e = find_identity(outer->exps, 
outer)) == NULL) {
+                                       if (find_identity(outer->exps, outer) 
== NULL) {
                                                e = rel_unop_(sql, 
outer->exps->h->data, NULL, "identity", card_value);
                                                set_intern(e);
                                                rel_project_add_exp(sql, outer, 
e);
_______________________________________________
Checkin-list mailing list
Checkin-list@monetdb.org
http://mail.monetdb.org/mailman/listinfo/checkin-list