MonetDB: Jul2012 - First do the cast, then do the shift.

[Sjoerd Mullender]

Changeset: 82d2673e17b2 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=82d2673e17b2
Modified Files:
        clients/odbc/driver/ODBCConvert.c
Branch: Jul2012
Log Message:

First do the cast, then do the shift.
"Suspicious sign extension" found by coverity.


diffs (12 lines):

diff --git a/clients/odbc/driver/ODBCConvert.c 
b/clients/odbc/driver/ODBCConvert.c
--- a/clients/odbc/driver/ODBCConvert.c
+++ b/clients/odbc/driver/ODBCConvert.c
@@ -2886,7 +2886,7 @@ ODBCStore(ODBCStmt *stmt,
                nval.sign = ((SQL_NUMERIC_STRUCT *) ptr)->sign;
                nval.val = 0;
                for (i = 0; i < SQL_MAX_NUMERIC_LEN; i++)
-                       nval.val |= ((SQL_NUMERIC_STRUCT *) ptr)->val[i] << (i 
* 8);
+                       nval.val |= (SQLUBIGINT) ((SQL_NUMERIC_STRUCT *) 
ptr)->val[i] << (i * 8);
                break;
        case SQL_C_FLOAT:
                fval = * (SQLREAL *) ptr;
_______________________________________________
Checkin-list mailing list
Checkin-list@monetdb.org
http://mail.monetdb.org/mailman/listinfo/checkin-list