MonetDB: Oct2012 - BATsetaccess: hide copy warning behind BATDEBUG

[Fabian Groffen]

Changeset: 17ce12cade7e for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=17ce12cade7e
Modified Files:
        gdk/gdk_bat.c
        monetdb5/extras/jaql/jaqltests/Tests/shred.stable.out
        monetdb5/extras/jaql/jaqltests/Tests/unroll.stable.out
Branch: Oct2012
Log Message:

BATsetaccess: hide copy warning behind BATDEBUG

Jaql code often triggers this "warning" (Mtest->propcheck), since jaql
assumes no knowledge about BAT's other than that it doesn't modify them,
unless it knows it had created them itself.  Many views result from
operators that optimise in a way not articulated though the input/output
interface.


diffs (35 lines):

diff --git a/gdk/gdk_bat.c b/gdk/gdk_bat.c
--- a/gdk/gdk_bat.c
+++ b/gdk/gdk_bat.c
@@ -2659,8 +2659,7 @@ BATsetaccess(BAT *b, int newmode)
                storage_t b0, b1, b2 = STORE_MEM, b3 = STORE_MEM;
 
                if (b->batSharecnt && newmode != BAT_READ) {
-
-                       PROPDEBUG THRprintf(GDKout, "#BATsetaccess: %s has %d 
views; deliver a copy.\n", BATgetId(b), b->batSharecnt);
+                       BATDEBUG THRprintf(GDKout, "#BATsetaccess: %s has %d 
views; creating a copy\n", BATgetId(b), b->batSharecnt);
                        b = BATsetaccess(BATcopy(b, b->htype, b->ttype, TRUE), 
newmode);
                        if (b && b->batStamp > 0)
                                b->batStamp = -b->batStamp;     /* prevent MIL 
setaccess */
diff --git a/monetdb5/extras/jaql/jaqltests/Tests/shred.stable.out 
b/monetdb5/extras/jaql/jaqltests/Tests/shred.stable.out
--- a/monetdb5/extras/jaql/jaqltests/Tests/shred.stable.out
+++ b/monetdb5/extras/jaql/jaqltests/Tests/shred.stable.out
@@ -111,7 +111,6 @@ Ready.
   }
 ]
 #a -> expand unroll $.menu.items -> filter $.menu.items.id == "OpenNew";
-#BATsetaccess: tmp_775 has 4 views; deliver a copy.
 % .json # table_name
 % json # name
 % clob # type
diff --git a/monetdb5/extras/jaql/jaqltests/Tests/unroll.stable.out 
b/monetdb5/extras/jaql/jaqltests/Tests/unroll.stable.out
--- a/monetdb5/extras/jaql/jaqltests/Tests/unroll.stable.out
+++ b/monetdb5/extras/jaql/jaqltests/Tests/unroll.stable.out
@@ -25,7 +25,6 @@ Ready.
 # 19:22:35 >  
 
 #a -> expand unroll $.menu.items;
-#BATsetaccess: tmp_775 has 4 views; deliver a copy.
 % .json # table_name
 % json # name
 % clob # type
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
http://mail.monetdb.org/mailman/listinfo/checkin-list