MonetDB: default - off must be signed as it can be negative,

[Stefan Manegold]

Changeset: f23abbc6e142 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=f23abbc6e142
Modified Files:
        gdk/gdk_select.c
Branch: default
Log Message:

off must be signed as it can be negative,
e.g., if b->hseqbase == 0 and b->U->first > 0;
instead of wrd, we could also use ssize_t or
int/lng with 32/64-bit OIDs


diffs (30 lines):

diff --git a/gdk/gdk_select.c b/gdk/gdk_select.c
--- a/gdk/gdk_select.c
+++ b/gdk/gdk_select.c
@@ -98,7 +98,11 @@ BAT_hashselect(BAT *b, BAT *s, BAT *bn, 
        BATiter bi;
        BUN i;
        oid o;
-       oid off;
+       /* off must be signed as it can be negative,
+        * e.g., if b->hseqbase == 0 and b->U->first > 0;
+        * instead of wrd, we could also use ssize_t or int/lng with
+        * 32/64-bit OIDs */
+       wrd off;
 
        assert(bn->htype == TYPE_void);
        assert(bn->ttype == TYPE_oid);
@@ -185,7 +189,12 @@ BAT_scanselect(BAT *b, BAT *s, BAT *bn, 
        BATiter bi = bat_iterator(b);
        int (*cmp)(const void *, const void *);
        BUN p, q;
-       oid o, off;
+       oid o;
+       /* off must be signed as it can be negative,
+        * e.g., if b->hseqbase == 0 and b->U->first > 0;
+        * instead of wrd, we could also use ssize_t or int/lng with
+        * 32/64-bit OIDs */
+       wrd off;
        const void *nil, *v;
        int c;
 
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
http://mail.monetdb.org/mailman/listinfo/checkin-list