Changeset: b771d5ee7d36 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=b771d5ee7d36
Modified Files:
sql/server/rel_bin.c
Branch: default
Log Message:
some comments for future fixes
diffs (20 lines):
diff --git a/sql/server/rel_bin.c b/sql/server/rel_bin.c
--- a/sql/server/rel_bin.c
+++ b/sql/server/rel_bin.c
@@ -1934,6 +1934,8 @@ rel2bin_except( mvc *sql, sql_rel *rel,
* as during joining nil != nil. But for except's nil aren't distinct.
* We would need a bat.join operator which has both semantics.
*/
+ /* TODO change to leftjoin semantics to keep those in A not in B */
+ /* would need outerjoin eqjoin and outer project code, cleans up
following mess */
s = stmt_releqjoin_init(sql->sa);
for (n = left->op4.lval->h, m = right->op4.lval->h; n && m; n =
n->next, m = m->next) {
stmt *l = column(sql->sa, n->data);
@@ -1955,6 +1957,7 @@ rel2bin_except( mvc *sql, sql_rel *rel,
stmt *glcnt, *grcnt, *o;
sql_subfunc *sub;
+ /* nil + count -> ? */
glcnt = stmt_project(sql->sa, lm, lcnt);
grcnt = stmt_project(sql->sa, rm, rcnt);
_______________________________________________
checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
