Changeset: 881606495806 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=881606495806
Modified Files:
gdk/gdk_bat.c
Branch: default
Log Message:
Assert that b->U->first == 0.
The first step to remove the BUNfirst() macro and all the complication
that introdudes because of different code use in gdk is to assert that
b->U->first is always 0. This assertion is not triggered anywhere during
the sql testing, but is been triggered in 3 tests in mserver5. Namely,
gdkTests/bat_insert gdkTests/reload and gdkTests/void will trigger
the assertion and that is most likely because of the bat.delete function
call. If we decide to go through and clean the code from BUNfirst,
b->U->first, offset, etc. then we have to probably remove the delete
functionality, but that sounds ok because no one is using it anyway.
diffs (11 lines):
diff --git a/gdk/gdk_bat.c b/gdk/gdk_bat.c
--- a/gdk/gdk_bat.c
+++ b/gdk/gdk_bat.c
@@ -3050,6 +3050,7 @@ BATassertProps(BAT *b)
assert(b->batFirst >= b->batDeleted);
assert(b->batInserted >= b->batFirst);
assert(b->batFirst + b->batCount >= b->batInserted);
+ assert(b->U->first == 0);
BATassertHeadProps(b);
if (b->H != bm->H)
_______________________________________________
checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list
