Changeset: 2c16ac0e23ba for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=2c16ac0e23ba
Modified Files:
        monetdb5/optimizer/opt_wrapper.c
Branch: Feb2013
Log Message:

avoid providing NULL pointer argument to "%s" in printf format string,
as that appears to result in a SEGFAULT on Solaris/SunOS.

This keeps tests
sql/test/BugTracker-2009/Tests/reorder.SF-2770608.sql
and
sql/test/BugTracker-2009/Tests/table-leftovers.SF-2779462.sql
from crashing on Solaris/SunOS.


Open question:

Is it correct that in line 178 of monetdb5/optimizer/opt_wrapper.c
throw(MAL, optimizer, RUNTIME_OBJECT_UNDEFINED ":%s.%s", modnme, fcnnme);
is called with modnme == NULL
?


diffs (12 lines):

diff --git a/monetdb5/optimizer/opt_wrapper.c b/monetdb5/optimizer/opt_wrapper.c
--- a/monetdb5/optimizer/opt_wrapper.c
+++ b/monetdb5/optimizer/opt_wrapper.c
@@ -123,7 +123,7 @@ opt_export str OPTwrapper(Client cntxt, 
 #define OPTIMIZERDEBUG if (0) 
 
 str OPTwrapper (Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr p){
-       str modnme = 0;
+       str modnme = "(NONE)";
        str fcnnme = 0;
        str msg= MAL_SUCCEED;
        Symbol s= NULL;
_______________________________________________
checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list

Reply via email to