MonetDB: Feb2013 - Reduce stack use and extra copying.

[Sjoerd Mullender]

Changeset: 642e54f89d3e for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=642e54f89d3e
Modified Files:
        gdk/gdk_storage.c
Branch: Feb2013
Log Message:

Reduce stack use and extra copying.


diffs (26 lines):

diff --git a/gdk/gdk_storage.c b/gdk/gdk_storage.c
--- a/gdk/gdk_storage.c
+++ b/gdk/gdk_storage.c
@@ -136,7 +136,7 @@ GDKremovedir(const char *dirname)
 int
 GDKfdlocate(const char *nme, const char *mode, const char *extension)
 {
-       char buf[PATHLENGTH], *path = buf;
+       char path[PATHLENGTH];
        int fd, flags = 0;
 
        if ((nme == NULL) || (*nme == 0)) {
@@ -164,11 +164,8 @@ GDKfdlocate(const char *nme, const char 
 #endif
        fd = open(path, flags, MONETDB_MODE);
        if (fd < 0 && *mode == 'w') {
-               /* try to create the directory, if that was the problem */
-               char tmp[PATHLENGTH];
-
-               strcpy(tmp, buf);
-               if (GDKcreatedir(tmp)) {
+               /* try to create the directory, in case that was the problem */
+               if (GDKcreatedir(path)) {
                        fd = open(path, flags, MONETDB_MODE);
                }
        }
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
http://mail.monetdb.org/mailman/listinfo/checkin-list