Changeset: 85081feca944 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=85081feca944
Modified Files:
monetdb5/modules/mal/mat.c
Branch: default
Log Message:
Beware of semantic issues in mat.c
The optimization to use mergepack requires more, you have to ensure that
all ranges are pairwise disjoint as well. Otherwise you
may loose elements. In the current(sep13) SQL setting
it did not create errors. Nevertheless it is postponed.
diffs (28 lines):
diff --git a/monetdb5/modules/mal/mat.c b/monetdb5/modules/mal/mat.c
--- a/monetdb5/modules/mal/mat.c
+++ b/monetdb5/modules/mal/mat.c
@@ -90,7 +90,6 @@ MATpackInternal(Client cntxt, MalBlkPtr
BAT *b, *bn;
BUN cap = 0;
int tt = TYPE_any;
- int sorted =1, keyed=1, voidheaded=1;
(void) cntxt;
(void) mb;
@@ -108,16 +107,11 @@ MATpackInternal(Client cntxt, MalBlkPtr
tt = b->ttype;
cap += BATcount(b);
}
- if ( !b->tsorted) sorted =0;
- if ( !b->tkey) keyed =0;
- if ( b->htype != TYPE_void ) voidheaded =0;
}
if (tt == TYPE_any){
*ret = 0;
return MAL_SUCCEED;
}
- if (tt == TYPE_oid && sorted && keyed && voidheaded)
- return MATmergepack(cntxt, mb, stk, p);
bn = BATnew(TYPE_void, tt, cap);
if (bn == NULL)
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
