MonetDB: Jan2014 - Avoid resource leak

[Martin Kersten]

Changeset: 8b7537b5dca6 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=8b7537b5dca6
Modified Files:
        monetdb5/modules/mal/urlbox.c
Branch: Jan2014
Log Message:

Avoid resource leak


diffs (31 lines):

diff --git a/monetdb5/modules/mal/urlbox.c b/monetdb5/modules/mal/urlbox.c
--- a/monetdb5/modules/mal/urlbox.c
+++ b/monetdb5/modules/mal/urlbox.c
@@ -199,6 +199,7 @@ URLBOXdepositFile(int *r, str *fnme){
        char *s,*t;
        int len=0;
        char buf[PATHLENGTH];
+       str msg= MAL_SUCCEED;
 
        (void) r; 
        if( **fnme == '/')
@@ -232,7 +233,9 @@ URLBOXdepositFile(int *r, str *fnme){
                        }
                        /* found a string to be processed */
                        *t = 0;
-                       URLBOXinsert(s);
+                       msg =URLBOXinsert(s);
+                       if( msg != MAL_SUCCEED)
+                               break;
                        *t= '\n';
                        s= t+1;
                        t= s;
@@ -242,7 +245,7 @@ URLBOXdepositFile(int *r, str *fnme){
        bstream_destroy(bs);
        mnstr_close(fs);
        mnstr_destroy(fs);
-       return MAL_SUCCEED;
+       return msg;
 }
 str
 URLBOXdeposit(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci)
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list