Changeset: 366cebe9e451 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=366cebe9e451
Added Files:
sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.sql
sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.err
sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.out
Modified Files:
monetdb5/modules/mal/tablet.c
sql/test/BugTracker-2014/Tests/All
Branch: Jul2015
Log Message:
allow null in strings, fixes bug 2014 (again).
diffs (140 lines):
diff --git a/monetdb5/modules/mal/tablet.c b/monetdb5/modules/mal/tablet.c
--- a/monetdb5/modules/mal/tablet.c
+++ b/monetdb5/modules/mal/tablet.c
@@ -991,9 +991,11 @@ SQLload_parse_line(READERtask *task, int
if (task->quote || task->seplen != 1) {
for (i = 0; i < as->nr_attrs; i++) {
+ int quote = 0;
task->fields[i][idx] = line;
/* recognize fields starting with a quote, keep them */
if (*line && *line == task->quote) {
+ quote = 1;
#ifdef _DEBUG_TABLET_
mnstr_printf(GDKout, "before #1 %s\n", s =
line);
#endif
@@ -1040,7 +1042,7 @@ SQLload_parse_line(READERtask *task, int
endoffieldcheck:
;
/* check for user defined NULL string */
- if (!fmt->skip && fmt->nullstr && task->fields[i][idx]
&& strncasecmp(task->fields[i][idx], fmt->nullstr, fmt->null_length + 1) == 0)
+ if (!fmt->skip && (!quote || !fmt->null_length) &&
fmt->nullstr && task->fields[i][idx] && strncasecmp(task->fields[i][idx],
fmt->nullstr, fmt->null_length + 1) == 0)
task->fields[i][idx] = 0;
}
goto endofline;
diff --git a/sql/test/BugTracker-2014/Tests/All
b/sql/test/BugTracker-2014/Tests/All
--- a/sql/test/BugTracker-2014/Tests/All
+++ b/sql/test/BugTracker-2014/Tests/All
@@ -69,3 +69,4 @@ combined_WHERE_conditions.Bug-3642
copy-into.Bug-3481
empty_intermediate_quantile.Bug-3611
uppercaseboolean.Bug-3519
+null_in_string.Bug-2014
diff --git a/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.sql
b/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.sql
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.sql
@@ -0,0 +1,8 @@
+
+CREATE TABLE x (a CLOB);
+COPY 3 RECORDS INTO x FROM STDIN USING DELIMITERS ',', '\n', '\'';
+'null'
+'aap'
+'beer'
+SELECT * FROM x WHERE a IS NULL;
+DROP TABLE x;
diff --git a/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.err
b/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.err
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.err
@@ -0,0 +1,37 @@
+stderr of test 'null_in_string.Bug-2014` in directory
'sql/test/BugTracker-2014` itself:
+
+
+# 17:30:12 >
+# 17:30:12 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=34120" "--set"
"mapi_usock=/var/tmp/mtest-26024/.s.monetdb.34120" "--set" "monet_prompt="
"--forcemito" "--set" "mal_listing=2"
"--dbpath=/home/niels/scratch/rc-monetdb/Linux-x86_64/var/MonetDB/mTests_sql_test_BugTracker-2014"
"--set" "mal_listing=0" "--set" "embedded_r=yes"
+# 17:30:12 >
+
+# builtin opt gdk_dbpath =
/home/niels/scratch/rc-monetdb/Linux-x86_64/var/monetdb5/dbfarm/demo
+# builtin opt gdk_debug = 0
+# builtin opt gdk_vmtrim = no
+# builtin opt monet_prompt = >
+# builtin opt monet_daemon = no
+# builtin opt mapi_port = 50000
+# builtin opt mapi_open = false
+# builtin opt mapi_autosense = false
+# builtin opt sql_optimizer = default_pipe
+# builtin opt sql_debug = 0
+# cmdline opt gdk_nr_threads = 0
+# cmdline opt mapi_open = true
+# cmdline opt mapi_port = 34120
+# cmdline opt mapi_usock = /var/tmp/mtest-26024/.s.monetdb.34120
+# cmdline opt monet_prompt =
+# cmdline opt mal_listing = 2
+# cmdline opt gdk_dbpath =
/home/niels/scratch/rc-monetdb/Linux-x86_64/var/MonetDB/mTests_sql_test_BugTracker-2014
+# cmdline opt mal_listing = 0
+# cmdline opt embedded_r = yes
+# cmdline opt gdk_debug = 536870922
+
+# 17:30:13 >
+# 17:30:13 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-26024" "--port=34120"
+# 17:30:13 >
+
+
+# 17:30:13 >
+# 17:30:13 > "Done."
+# 17:30:13 >
+
diff --git a/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.out
b/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.out
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2014/Tests/null_in_string.Bug-2014.stable.out
@@ -0,0 +1,48 @@
+stdout of test 'null_in_string.Bug-2014` in directory
'sql/test/BugTracker-2014` itself:
+
+
+# 17:30:12 >
+# 17:30:12 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=34120" "--set"
"mapi_usock=/var/tmp/mtest-26024/.s.monetdb.34120" "--set" "monet_prompt="
"--forcemito" "--set" "mal_listing=2"
"--dbpath=/home/niels/scratch/rc-monetdb/Linux-x86_64/var/MonetDB/mTests_sql_test_BugTracker-2014"
"--set" "mal_listing=0" "--set" "embedded_r=yes"
+# 17:30:12 >
+
+# MonetDB 5 server v11.21.12
+# This is an unreleased version
+# Serving database 'mTests_sql_test_BugTracker-2014', using 4 threads
+# Compiled for x86_64-unknown-linux-gnu/64bit with 64bit OIDs and 128bit
integers dynamically linked
+# Found 7.333 GiB available main-memory.
+# Copyright (c) 1993-July 2008 CWI.
+# Copyright (c) August 2008-2015 MonetDB B.V., all rights reserved
+# Visit http://www.monetdb.org/ for further information
+# Listening for connection requests on mapi:monetdb://localhost.nes.nl:34120/
+# Listening for UNIX domain connection requests on
mapi:monetdb:///var/tmp/mtest-26024/.s.monetdb.34120
+# MonetDB/GIS module loaded
+# Start processing logs sql/sql_logs version 52200
+# Start reading the write-ahead log 'sql_logs/sql/log.28'
+# Finished reading the write-ahead log 'sql_logs/sql/log.28'
+# Finished processing logs sql/sql_logs
+# MonetDB/SQL module loaded
+# MonetDB/R module loaded
+
+Ready.
+
+# 17:30:13 >
+# 17:30:13 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-26024" "--port=34120"
+# 17:30:13 >
+
+#CREATE TABLE x (a CLOB);
+#COPY 3 RECORDS INTO x FROM STDIN USING DELIMITERS ',', '\n', '\'';
+#'null'
+#'aap'
+#'beer'
+[ 3 ]
+#SELECT * FROM x WHERE a IS NULL;
+% sys.x # table_name
+% a # name
+% clob # type
+% 0 # length
+#DROP TABLE x;
+
+# 17:30:13 >
+# 17:30:13 > "Done."
+# 17:30:13 >
+
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
