Changeset: fe44b5773360 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=fe44b5773360 Modified Files: gdk/gdk_bbp.c Branch: Jun2016 Log Message:
Reenable unsharing of bats in BBPexit: it turns out it is needed.
Also added a comment about why its needed.
diffs (32 lines):
diff --git a/gdk/gdk_bbp.c b/gdk/gdk_bbp.c
--- a/gdk/gdk_bbp.c
+++ b/gdk/gdk_bbp.c
@@ -1448,8 +1448,13 @@ BBPexit(void)
skipped = 1;
continue;
}
- /* NIELS ?? Why reduce share count,
it's done in VIEWdestroy !!
if (isVIEW(b)) {
+ /* "manually"
+ * decrement parent
+ * references, since
+ * VIEWdestroy doesn't
+ * (and can't here due
+ * to locks) do it */
bat hp = VIEWhparent(b), tp =
VIEWtparent(b);
bat vhp = VIEWvhparent(b), vtp
= VIEWvtparent(b);
if (hp) {
@@ -1468,11 +1473,10 @@ BBPexit(void)
BBP_cache(vtp)->batSharecnt--;
--BBP_lrefs(vtp);
}
- }*/
- if (isVIEW(b))
VIEWdestroy(b);
- else
+ } else {
BATfree(b);
+ }
}
BBPuncacheit(i, TRUE);
if (BBP_logical(i) != BBP_bak(i))
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
