Changeset: 1c3409c82f28 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=1c3409c82f28
Modified Files:
        java/src/main/java/nl/cwi/monetdb/client/JdbcClient.java
Branch: default
Log Message:

Fix some resourceleaks in JdbcClient by adding ResultSet close() calls.
After using a ResultSet always close it asap to release server resources.


diffs (29 lines):

diff --git a/java/src/main/java/nl/cwi/monetdb/client/JdbcClient.java 
b/java/src/main/java/nl/cwi/monetdb/client/JdbcClient.java
--- a/java/src/main/java/nl/cwi/monetdb/client/JdbcClient.java
+++ b/java/src/main/java/nl/cwi/monetdb/client/JdbcClient.java
@@ -276,6 +276,8 @@ copts.produceHelpMessage()
                                        tbl.getString("TABLE_NAME"),
                                        tbl.getString("TABLE_TYPE")));
                        }
+                       tbl.close();
+                       tbl = null;
 
                        if (xmlMode) {
                                e = new XMLExporter(out);
@@ -324,6 +326,8 @@ copts.produceHelpMessage()
                                        // add PK table dependancy to FK table
                                        fk.addDependancy(pk);
                                }
+                               tbl.close();
+                               tbl = null;
 
                                // search for cycles of type a -> (x ->)+ b 
probably not
                                // the most optimal way, but it works by just 
scanning
@@ -791,6 +795,7 @@ copts.produceHelpMessage()
                                                out.println(aff + " affected 
row" +
                                                                (aff != 1 ? "s" 
: ""));
                                        }
+                                       rs.close();
                                }
                        }
 
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list

Reply via email to