Changeset: 1a7503cfb2be for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=1a7503cfb2be
Modified Files:
monetdb5/mal/mal_authorize.c
monetdb5/modules/mal/remote.c
Branch: remote_auth
Log Message:
Some todo items in comments
Previous commits in this branch broke the sql/test/ifexists test. We
need to fix it.
diffs (44 lines):
diff --git a/monetdb5/mal/mal_authorize.c b/monetdb5/mal/mal_authorize.c
--- a/monetdb5/mal/mal_authorize.c
+++ b/monetdb5/mal/mal_authorize.c
@@ -823,6 +823,8 @@ AUTHverifyPassword(const char *passwd)
#endif
}
+/* change name to remote table uri, add client to check that the user
+ * has permissions */
str
AUTHgetRemoteTableCredentials(const char *name, str *username, str *password)
{
@@ -844,6 +846,7 @@ AUTHgetRemoteTableCredentials(const char
return MAL_SUCCEED;
}
+/* change name to remote table uri, add local user */
str
AUTHaddRemoteTableCredentials(const char *name, const char *user, const char
*pass, bool pw_encrypted)
{
diff --git a/monetdb5/modules/mal/remote.c b/monetdb5/modules/mal/remote.c
--- a/monetdb5/modules/mal/remote.c
+++ b/monetdb5/modules/mal/remote.c
@@ -56,6 +56,8 @@
#include "monetdb_config.h"
#include "remote.h"
+#include "mal_authorize.h"
+
/*
* Technically, these methods need to be serialised per connection,
* hence a scheduler that interleaves e.g. multiple get calls, simply
@@ -160,6 +162,11 @@ str RMTconnectScen(
/* just make sure the return isn't garbage */
*ret = 0;
+ /* TODO:
+ * 1. remote user and password from arg list
+ * 2. use AUTHgetRemoteTableCredentials(uri, client)
+ */
+
if (ouri == NULL || *ouri == NULL || strcmp(*ouri, (str)str_nil) == 0)
throw(ILLARG, "remote.connect", ILLEGAL_ARGUMENT ": database
uri "
"is NULL or nil");
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
