Changeset: 12a61dac9008 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=12a61dac9008
Added Files:
sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.err
sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.out
Modified Files:
sql/backends/monet5/sql_result.c
sql/server/rel_dump.c
sql/test/BugDay_2005-10-06_2.9.3/Tests/UNION_JOIN_vs_plain_set_UNION-2.SF-920585.stable.out
sql/test/Tests/coalesce.stable.out
sql/test/Tests/string.stable.out
Branch: Mar2018
Log Message:
fixes for bug 6583 and 6584
diffs (176 lines):
diff --git a/sql/backends/monet5/sql_result.c b/sql/backends/monet5/sql_result.c
--- a/sql/backends/monet5/sql_result.c
+++ b/sql/backends/monet5/sql_result.c
@@ -1932,7 +1932,7 @@ get_print_width(int mtype, int eclass, i
incr = 2;
mtype = ATOMbasetype(mtype);
if (mtype == TYPE_str) {
- if (eclass == EC_CHAR) {
+ if (eclass == EC_CHAR && digits) {
return digits;
} else {
int l = 0;
diff --git a/sql/server/rel_dump.c b/sql/server/rel_dump.c
--- a/sql/server/rel_dump.c
+++ b/sql/server/rel_dump.c
@@ -1135,9 +1135,12 @@ exp_read(mvc *sql, sql_rel *lrel, sql_re
sql_exp *e;
e = exp_read(sql, lrel, rrel, pexps, r, pos, 0);
- if (e && e->type == e_cmp)
- return exp_compare2(sql->sa, e->l, exp, e->r,
compare2range(swap_compare((comp_type)f),e->flag));
- else if (e)
+ if (e && e->type == e_cmp) {
+ sql_exp *ne = exp_compare2(sql->sa, e->l, exp,
e->r, compare2range(swap_compare((comp_type)f), e->flag));
+ if (is_anti(exp))
+ set_anti(ne);
+ return ne;
+ } else if (e)
return exp_compare(sql->sa, exp, e, f);
}
}
diff --git
a/sql/test/BugDay_2005-10-06_2.9.3/Tests/UNION_JOIN_vs_plain_set_UNION-2.SF-920585.stable.out
b/sql/test/BugDay_2005-10-06_2.9.3/Tests/UNION_JOIN_vs_plain_set_UNION-2.SF-920585.stable.out
---
a/sql/test/BugDay_2005-10-06_2.9.3/Tests/UNION_JOIN_vs_plain_set_UNION-2.SF-920585.stable.out
+++
b/sql/test/BugDay_2005-10-06_2.9.3/Tests/UNION_JOIN_vs_plain_set_UNION-2.SF-920585.stable.out
@@ -102,7 +102,7 @@ Ready.
% .tables, .tables, .tables, .tables, .tables,
.tables, .tables, .tables, .tables, .tables #
table_name
% table_cat, table_schem, table_name, table_type, remarks,
type_cat, type_schem, type_name, self_referencing_col_name,
ref_generation # name
% char, varchar, varchar, char, char, char, char,
char, char, char # type
-% 4, 3, 8, 12, 0, 4, 4, 4, 2, 6 #
length
+% 4, 3, 8, 12, 222, 4, 4, 4, 2, 6 #
length
[ "null", "sys", "columns", "SYSTEM TABLE", "", "null", "null",
"null", "id", "SYSTEM" ]
[ "null", "sys", "db_scens", "SYSTEM TABLE", "", "null", "null",
"null", "id", "SYSTEM" ]
[ "null", "sys", "db_users", "SYSTEM TABLE", "", "null", "null",
"null", "id", "SYSTEM" ]
diff --git a/sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.err
b/sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.err
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.err
@@ -0,0 +1,35 @@
+stderr of test 'concat-str-int.Bug-6583` in directory
'sql/test/BugTracker-2018` itself:
+
+
+# 17:02:05 >
+# 17:02:05 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=38716" "--set"
"mapi_usock=/var/tmp/mtest-25700/.s.monetdb.38716" "--set" "monet_prompt="
"--forcemito"
"--dbpath=/home/niels/scratch/rc-old/Linux-x86_64/var/MonetDB/mTests_sql_test_BugTracker-2018"
"--set" "embedded_c=true"
+# 17:02:05 >
+
+# builtin opt gdk_dbpath =
/home/niels/scratch/rc-old/Linux-x86_64/var/monetdb5/dbfarm/demo
+# builtin opt gdk_debug = 0
+# builtin opt gdk_vmtrim = no
+# builtin opt monet_prompt = >
+# builtin opt monet_daemon = no
+# builtin opt mapi_port = 50000
+# builtin opt mapi_open = false
+# builtin opt mapi_autosense = false
+# builtin opt sql_optimizer = default_pipe
+# builtin opt sql_debug = 0
+# cmdline opt gdk_nr_threads = 0
+# cmdline opt mapi_open = true
+# cmdline opt mapi_port = 38716
+# cmdline opt mapi_usock = /var/tmp/mtest-25700/.s.monetdb.38716
+# cmdline opt monet_prompt =
+# cmdline opt gdk_dbpath =
/home/niels/scratch/rc-old/Linux-x86_64/var/MonetDB/mTests_sql_test_BugTracker-2018
+# cmdline opt embedded_c = true
+# cmdline opt gdk_debug = 553648138
+
+# 17:02:06 >
+# 17:02:06 > "mclient" "-lsql" "-ftest" "-tnone" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-25700" "--port=38716"
+# 17:02:06 >
+
+
+# 17:02:06 >
+# 17:02:06 > "Done."
+# 17:02:06 >
+
diff --git a/sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.out
b/sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.out
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2018/Tests/concat-str-int.Bug-6583.stable.out
@@ -0,0 +1,55 @@
+stdout of test 'concat-str-int.Bug-6583` in directory
'sql/test/BugTracker-2018` itself:
+
+
+# 17:02:05 >
+# 17:02:05 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=38716" "--set"
"mapi_usock=/var/tmp/mtest-25700/.s.monetdb.38716" "--set" "monet_prompt="
"--forcemito"
"--dbpath=/home/niels/scratch/rc-old/Linux-x86_64/var/MonetDB/mTests_sql_test_BugTracker-2018"
"--set" "embedded_c=true"
+# 17:02:05 >
+
+# MonetDB 5 server v11.29.2
+# This is an unreleased version
+# Serving database 'mTests_sql_test_BugTracker-2018', using 8 threads
+# Compiled for x86_64-unknown-linux-gnu/64bit
+# Found 15.387 GiB available main-memory.
+# Copyright (c) 1993 - July 2008 CWI.
+# Copyright (c) August 2008 - 2018 MonetDB B.V., all rights reserved
+# Visit https://www.monetdb.org/ for further information
+# Listening for connection requests on mapi:monetdb://xps13:38716/
+# Listening for UNIX domain connection requests on
mapi:monetdb:///var/tmp/mtest-25700/.s.monetdb.38716
+# MonetDB/GIS module loaded
+# MonetDB/SQL module loaded
+
+Ready.
+
+# 17:02:06 >
+# 17:02:06 > "mclient" "-lsql" "-ftest" "-tnone" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-25700" "--port=38716"
+# 17:02:06 >
+
+#select '12345' || 678;
+% .L2 # table_name
+% L2 # name
+% char # type
+% 8 # length
+[ "12345678" ]
+#select 12345 || '678';
+% .L2 # table_name
+% L2 # name
+% clob # type
+% 8 # length
+[ "12345678" ]
+#select '12345' || '678';
+% .L2 # table_name
+% L2 # name
+% varchar # type
+% 8 # length
+[ "12345678" ]
+#select 12345 || 678;
+% .L2 # table_name
+% L2 # name
+% clob # type
+% 8 # length
+[ "12345678" ]
+
+# 17:02:06 >
+# 17:02:06 > "Done."
+# 17:02:06 >
+
diff --git a/sql/test/Tests/coalesce.stable.out
b/sql/test/Tests/coalesce.stable.out
--- a/sql/test/Tests/coalesce.stable.out
+++ b/sql/test/Tests/coalesce.stable.out
@@ -46,7 +46,7 @@ Ready.
[ 1 ]
[ 1 ]
#select avg(coalesce(age,38)) from coalescetest;
-% sys.L4 # table_name
+% sys.L3 # table_name
% L3 # name
% double # type
% 24 # length
@@ -91,7 +91,7 @@ Ready.
% .L2 # table_name
% L2 # name
% char # type
-% 0 # length
+% 1 # length
[ "x" ]
% sys.coalescetest, sys.coalescetest, sys.coalescetest # table_name
% id, name, age # name
diff --git a/sql/test/Tests/string.stable.out b/sql/test/Tests/string.stable.out
--- a/sql/test/Tests/string.stable.out
+++ b/sql/test/Tests/string.stable.out
@@ -131,7 +131,7 @@ Ready.
% sys.L2, sys.stringtest # table_name
% L2, str # name
% char, varchar # type
-% 0, 6 # length
+% 1, 6 # length
[ NULL, "" ]
[ "t", "test" ]
[ NULL, "" ]
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
