Changeset: 51d836f837af for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=51d836f837af
Modified Files:
sql/server/rel_sequence.c
Branch: Aug2018
Log Message:
Use the generated id of store_next_oid() when creating the sequence name,
instead of calling store_next_oid() again.
This makes the ids for implicitly created sequences (as part of a created
table) consecutive, so without gaps.
Also removed unnessary " " in static strings.
diffs (30 lines):
diff --git a/sql/server/rel_sequence.c b/sql/server/rel_sequence.c
--- a/sql/server/rel_sequence.c
+++ b/sql/server/rel_sequence.c
@@ -20,7 +20,7 @@ sql_next_seq_name(mvc *m)
oid len = 5 + ((id+7)>>3);
char *msg = sa_alloc(m->sa, len);
- snprintf(msg, len, "seq_%d", store_next_oid());
+ snprintf(msg, len, "seq_%d", id);
return msg;
}
@@ -96,7 +96,7 @@ rel_create_seq(
s = ss;
(void) tpe;
if (find_sql_sequence(s, name)) {
- return sql_error(sql, 02, SQLSTATE(42000) "CREATE SEQUENCE: "
"name '%s' already in use", name);
+ return sql_error(sql, 02, SQLSTATE(42000) "CREATE SEQUENCE:
name '%s' already in use", name);
} else if (!mvc_schema_privs(sql, s)) {
return sql_error(sql, 02, SQLSTATE(42000) "CREATE SEQUENCE:
insufficient privileges "
"for '%s' in schema '%s'",
stack_get_string(sql, "current_user"), s->base.name);
@@ -225,7 +225,7 @@ rel_alter_seq(
s = ss;
(void) tpe;
if (!(seq = find_sql_sequence(s, name))) {
- return sql_error(sql, 02, SQLSTATE(42000) "ALTER SEQUENCE: "
"no such sequence '%s'", name);
+ return sql_error(sql, 02, SQLSTATE(42000) "ALTER SEQUENCE: no
such sequence '%s'", name);
}
if (!mvc_schema_privs(sql, s)) {
return sql_error(sql, 02, SQLSTATE(42000) "ALTER SEQUENCE:
insufficient privileges "
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
