Changeset: f366f7e5632d for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=f366f7e5632d
Added Files:
sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.sql
sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.err
sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.out
Modified Files:
gdk/gdk_aggr.c
sql/test/BugTracker-2018/Tests/All
Branch: Aug2018
Log Message:
Added test and fix for bug 6658 (i.e. check for null quantile value).
diffs (200 lines):
diff --git a/gdk/gdk_aggr.c b/gdk/gdk_aggr.c
--- a/gdk/gdk_aggr.c
+++ b/gdk/gdk_aggr.c
@@ -2735,9 +2735,10 @@ BATgroupquantile(BAT *b, BAT *g, BAT *e,
return NULL;
}
- if (BATcount(b) == 0 || ngrp == 0) {
+ if (BATcount(b) == 0 || ngrp == 0 || is_dbl_nil(quantile)) {
/* trivial: no values, thus also no quantiles,
- * so return bat aligned with e with nil in the tail */
+ * so return bat aligned with e with nil in the tail
+ * The same happens for a NULL quantile */
return BATconstant(ngrp == 0 ? 0 : min, tp, nil, ngrp,
TRANSIENT);
}
diff --git a/sql/test/BugTracker-2018/Tests/All
b/sql/test/BugTracker-2018/Tests/All
--- a/sql/test/BugTracker-2018/Tests/All
+++ b/sql/test/BugTracker-2018/Tests/All
@@ -90,3 +90,4 @@ in-subquery-having-Bug-6651
create_table_empty_column_name.Bug-6653
select_where_true.Bug-6654
alter-sequence-subquery.Bug-6657
+quantile-crash.Bug-6658
diff --git a/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.sql
b/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.sql
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.sql
@@ -0,0 +1,12 @@
+start transaction;
+create table "test" (good integer, bad integer);
+insert into "test" (good, bad) values (1, null);
+select * from "test";
+select sys.quantile(good, 0.9) from "test";
+select sys.quantile(bad, 0.9) from "test" where bad is not null;
+select sys.quantile(bad, 0.9) from "test";
+select stddev_samp(bad), stddev_pop(bad), var_samp(bad), median(bad),
quantile(1, bad), quantile(bad, 1),
+ quantile(bad, bad), corr(1, bad), corr(bad, 1), corr(bad, bad) from
"test" where bad is not null;
+select stddev_samp(bad), stddev_pop(bad), var_samp(bad), median(bad),
quantile(1, bad), quantile(bad, 1),
+ quantile(bad, bad), corr(1, bad), corr(bad, 1), corr(bad, bad) from
"test";
+rollback;
diff --git a/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.err
b/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.err
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.err
@@ -0,0 +1,35 @@
+stderr of test 'quantile-crash.Bug-6658` in directory
'sql/test/BugTracker-2018` itself:
+
+
+# 10:32:48 >
+# 10:32:48 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=38192" "--set"
"mapi_usock=/var/tmp/mtest-25694/.s.monetdb.38192" "--set" "monet_prompt="
"--forcemito"
"--dbpath=/home/ferreira/repositories/MonetDB-Aug2018/BUILD/var/MonetDB/mTests_sql_test_BugTracker-2018"
"--set" "embedded_c=true"
+# 10:32:48 >
+
+# builtin opt gdk_dbpath =
/home/ferreira/repositories/MonetDB-Aug2018/BUILD/var/monetdb5/dbfarm/demo
+# builtin opt gdk_debug = 0
+# builtin opt gdk_vmtrim = no
+# builtin opt monet_prompt = >
+# builtin opt monet_daemon = no
+# builtin opt mapi_port = 50000
+# builtin opt mapi_open = false
+# builtin opt mapi_autosense = false
+# builtin opt sql_optimizer = default_pipe
+# builtin opt sql_debug = 0
+# cmdline opt gdk_nr_threads = 0
+# cmdline opt mapi_open = true
+# cmdline opt mapi_port = 38192
+# cmdline opt mapi_usock = /var/tmp/mtest-25694/.s.monetdb.38192
+# cmdline opt monet_prompt =
+# cmdline opt gdk_dbpath =
/home/ferreira/repositories/MonetDB-Aug2018/BUILD/var/MonetDB/mTests_sql_test_BugTracker-2018
+# cmdline opt embedded_c = true
+# cmdline opt gdk_debug = 553648138
+
+# 10:32:48 >
+# 10:32:48 > "mclient" "-lsql" "-ftest" "-tnone" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-25694" "--port=38192"
+# 10:32:48 >
+
+
+# 10:32:48 >
+# 10:32:48 > "Done."
+# 10:32:48 >
+
diff --git a/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.out
b/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.out
new file mode 100644
--- /dev/null
+++ b/sql/test/BugTracker-2018/Tests/quantile-crash.Bug-6658.stable.out
@@ -0,0 +1,114 @@
+stdout of test 'quantile-crash.Bug-6658` in directory
'sql/test/BugTracker-2018` itself:
+
+
+# 10:32:48 >
+# 10:32:48 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set"
"mapi_open=true" "--set" "mapi_port=38192" "--set"
"mapi_usock=/var/tmp/mtest-25694/.s.monetdb.38192" "--set" "monet_prompt="
"--forcemito"
"--dbpath=/home/ferreira/repositories/MonetDB-Aug2018/BUILD/var/MonetDB/mTests_sql_test_BugTracker-2018"
"--set" "embedded_c=true"
+# 10:32:48 >
+
+# MonetDB 5 server v11.31.12
+# This is an unreleased version
+# Serving database 'mTests_sql_test_BugTracker-2018', using 8 threads
+# Compiled for x86_64-pc-linux-gnu/64bit with 128bit integers
+# Found 15.492 GiB available main-memory.
+# Copyright (c) 1993 - July 2008 CWI.
+# Copyright (c) August 2008 - 2018 MonetDB B.V., all rights reserved
+# Visit https://www.monetdb.org/ for further information
+# Listening for connection requests on mapi:monetdb://wired-142.cwi.nl:38192/
+# Listening for UNIX domain connection requests on
mapi:monetdb:///var/tmp/mtest-25694/.s.monetdb.38192
+# MonetDB/GIS module loaded
+# SQL catalog created, loading sql scripts once
+# loading sql script: 09_like.sql
+# loading sql script: 10_math.sql
+# loading sql script: 11_times.sql
+# loading sql script: 12_url.sql
+# loading sql script: 13_date.sql
+# loading sql script: 14_inet.sql
+# loading sql script: 15_querylog.sql
+# loading sql script: 16_tracelog.sql
+# loading sql script: 17_temporal.sql
+# loading sql script: 18_index.sql
+# loading sql script: 20_vacuum.sql
+# loading sql script: 21_dependency_views.sql
+# loading sql script: 22_clients.sql
+# loading sql script: 23_skyserver.sql
+# loading sql script: 25_debug.sql
+# loading sql script: 26_sysmon.sql
+# loading sql script: 27_rejects.sql
+# loading sql script: 39_analytics.sql
+# loading sql script: 39_analytics_hge.sql
+# loading sql script: 40_geom.sql
+# loading sql script: 40_json.sql
+# loading sql script: 40_json_hge.sql
+# loading sql script: 41_md5sum.sql
+# loading sql script: 45_uuid.sql
+# loading sql script: 46_profiler.sql
+# loading sql script: 51_sys_schema_extension.sql
+# loading sql script: 60_wlcr.sql
+# loading sql script: 72_fits.sql
+# loading sql script: 74_netcdf.sql
+# loading sql script: 75_lidar.sql
+# loading sql script: 75_shp.sql
+# loading sql script: 75_storagemodel.sql
+# loading sql script: 80_statistics.sql
+# loading sql script: 80_udf.sql
+# loading sql script: 80_udf_hge.sql
+# loading sql script: 85_bam.sql
+# loading sql script: 90_generator.sql
+# loading sql script: 90_generator_hge.sql
+# loading sql script: 99_system.sql
+# MonetDB/SQL module loaded
+
+Ready.
+
+# 10:32:48 >
+# 10:32:48 > "mclient" "-lsql" "-ftest" "-tnone" "-Eutf-8" "-i" "-e"
"--host=/var/tmp/mtest-25694" "--port=38192"
+# 10:32:48 >
+
+#start transaction;
+#create table "test" (good integer, bad integer);
+#insert into "test" (good, bad) values (1, null);
+[ 1 ]
+#select * from "test";
+% sys.test, sys.test # table_name
+% good, bad # name
+% int, int # type
+% 1, 1 # length
+[ 1, NULL ]
+#select sys.quantile(good, 0.9) from "test";
+% sys.L3 # table_name
+% L3 # name
+% int # type
+% 1 # length
+[ 1 ]
+#select sys.quantile(bad, 0.9) from "test" where bad is not null;
+% sys.L3 # table_name
+% L3 # name
+% int # type
+% 1 # length
+[ NULL ]
+#select sys.quantile(bad, 0.9) from "test";
+% sys.L3 # table_name
+% L3 # name
+% int # type
+% 1 # length
+[ NULL ]
+#select stddev_samp(bad), stddev_pop(bad), var_samp(bad), median(bad),
quantile(1, bad), quantile(bad, 1),
+# quantile(bad, bad), corr(1, bad), corr(bad, 1), corr(bad, bad) from
"test" where bad is not null;
+% sys.L3, sys.L5, sys.L7, sys.L11, .L13, sys.L15,
sys.L17, .L21, sys.L23, sys.L25 # table_name
+% L3, L5, L7, L11, L13, L15, L17, L21, L23, L25 #
name
+% double, double, double, int, tinyint, int, int, double,
double, double # type
+% 24, 24, 24, 1, 1, 1, 1, 24, 24, 24 #
length
+[ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL ]
+#select stddev_samp(bad), stddev_pop(bad), var_samp(bad), median(bad),
quantile(1, bad), quantile(bad, 1),
+# quantile(bad, bad), corr(1, bad), corr(bad, 1), corr(bad, bad) from
"test";
+% sys.L3, sys.L5, sys.L7, sys.L11, .L13, sys.L15,
sys.L17, .L21, sys.L23, sys.L25 # table_name
+% L3, L5, L7, L11, L13, L15, L17, L21, L23, L25 #
name
+% double, double, double, int, tinyint, int, int, double,
double, double # type
+% 24, 24, 24, 1, 1, 1, 1, 24, 24, 24 #
length
+[ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL ]
+#rollback;
+
+# 10:32:48 >
+# 10:32:48 > "Done."
+# 10:32:48 >
+
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
