Changeset: 4d90f3f2dc9d for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=4d90f3f2dc9d
Modified Files:
sql/server/rel_select.c
Branch: default
Log Message:
When referencing order by expressions in a windowing query, pass ordering flags
as well.
This should fix TPC-DS query 51.
diffs (20 lines):
diff --git a/sql/server/rel_select.c b/sql/server/rel_select.c
--- a/sql/server/rel_select.c
+++ b/sql/server/rel_select.c
@@ -4915,9 +4915,13 @@ rel_rankop(mvc *sql, sql_rel **rel, symb
}
for(n = obe->h ; n ; n = n->next) {
- sql_exp *en = n->data;
-
- n->data = opt_groupby_add_exp(sql, p, pp, en);
+ sql_exp *oexp = n->data, *nexp;
+
+ n->data = nexp = opt_groupby_add_exp(sql, p, pp, oexp);
+ if (is_ascending(oexp))
+ set_direction(nexp, 1);
+ if (nulls_last(oexp))
+ set_direction(nexp, 2);
}
if (p->r) {
p->r = list_merge(sa_list(sql->sa), p->r, (fdup)NULL);
/* make sure the p->r is a different list than the gbe list */
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
