Changeset: 27d795f43aa4 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=27d795f43aa4
Modified Files:
clients/Tests/MAL-signatures.stable.out
clients/Tests/MAL-signatures.stable.out.int128
sql/backends/monet5/Tests/simpleSQL.malC
sql/backends/monet5/Tests/simpleSQL.stable.out
sql/backends/monet5/mal_backend.c
sql/backends/monet5/mal_backend.h
sql/backends/monet5/sql.mal
sql/backends/monet5/sql_scenario.c
sql/backends/monet5/sql_scenario.h
Branch: default
Log Message:
Cleanup: removed sql.start* and sql.init (sql.eval stays)
removed special cases for console
diffs (287 lines):
diff --git a/clients/Tests/MAL-signatures.stable.out
b/clients/Tests/MAL-signatures.stable.out
--- a/clients/Tests/MAL-signatures.stable.out
+++ b/clients/Tests/MAL-signatures.stable.out
@@ -11724,7 +11724,6 @@ stdout of test 'MAL-signatures` in direc
[ "sql", "grow", "pattern sql.grow(tid:bat[:oid], X_0:any_1):int ",
"mvc_grow_wrap;", "Resize the tid column of a declared table." ]
[ "sql", "importTable", "unsafe pattern sql.importTable(sname:str,
tname:str, onclient:int, fname:str...):bat[:any]... ",
"mvc_bin_import_table_wrap;", "Import a table from the files (fname)" ]
[ "sql", "include", "pattern sql.include(fname:str):void ",
"SQLinclude;", "Compile and execute a sql statements on the file" ]
-[ "sql", "init", "pattern sql.init():void ", "SQLinitEnvironment;",
"Initialize the environment for MAL" ]
[ "sql", "lag", "pattern sql.lag(b:any_1, l:any_2, d:any_1, p:any_3,
o:any_4):any_1 ", "SQLlag;", "return the value in the previous 'l' row in
the partition or 'd' if non existent" ]
[ "sql", "lag", "pattern sql.lag(b:any_1, l:any_2, d:bat[:any_1],
p:any_3, o:any_4):any_1 ", "SQLlag;", "return the value in the previous
'l' row in the partition or 'd' if non existent" ]
[ "sql", "lag", "pattern sql.lag(b:any_1, l:any_2, p:any_3,
o:any_4):any_1 ", "SQLlag;", "return the value in the previous 'l' row
in the partition or NULL if non existent" ]
@@ -11801,8 +11800,6 @@ stdout of test 'MAL-signatures` in direc
[ "sql", "single", "pattern sql.single(x:any_2):bat[:any_2] ",
"CMDBATsingle;", "" ]
[ "sql", "sql_environment", "inline function sql.sql_environment()
(name:bat[:str], value:bat[:str]);", "", "" ]
[ "sql", "sql_variables", "pattern sql.sql_variables():bat[:str]
", "sql_variables;", "return the table with session variables"
]
-[ "sql", "start", "pattern sql.start():void ", "SQLsession;",
"Switch to processing SQL statements" ]
-[ "sql", "start2", "pattern sql.start2():void ", "SQLsession2;",
"Switch to processing precompiled sql statements" ]
[ "sql", "storage", "pattern sql.storage() (schema:bat[:str],
table:bat[:str], column:bat[:str], type:bat[:str], mode:bat[:str],
location:bat[:str], count:bat[:lng], atomwidth:bat[:int], columnsize:bat[:lng],
heap:bat[:lng], hashes:bat[:lng], phash:bat[:bit], imprints:bat[:lng],
sorted:bat[:bit], revsorted:bat[:bit], key:bat[:bit], orderidx:bat[:lng]) ",
"sql_storage;", "return a table with storage information " ]
[ "sql", "storage", "pattern sql.storage(sname:str)
(schema:bat[:str], table:bat[:str], column:bat[:str], type:bat[:str],
mode:bat[:str], location:bat[:str], count:bat[:lng], atomwidth:bat[:int],
columnsize:bat[:lng], heap:bat[:lng], hashes:bat[:lng], phash:bat[:bit],
imprints:bat[:lng], sorted:bat[:bit], revsorted:bat[:bit], key:bat[:bit],
orderidx:bat[:lng]) ", "sql_storage;", "return a table with storage
information for a particular schema " ]
[ "sql", "storage", "pattern sql.storage(sname:str, tname:str)
(schema:bat[:str], table:bat[:str], column:bat[:str], type:bat[:str],
mode:bat[:str], location:bat[:str], count:bat[:lng], atomwidth:bat[:int],
columnsize:bat[:lng], heap:bat[:lng], hashes:bat[:lng], phash:bat[:bit],
imprints:bat[:lng], sorted:bat[:bit], revsorted:bat[:bit], key:bat[:bit],
orderidx:bat[:lng]) ", "sql_storage;", "return a table with storage
information for a particular table" ]
diff --git a/clients/Tests/MAL-signatures.stable.out.int128
b/clients/Tests/MAL-signatures.stable.out.int128
--- a/clients/Tests/MAL-signatures.stable.out.int128
+++ b/clients/Tests/MAL-signatures.stable.out.int128
@@ -16138,7 +16138,6 @@ stdout of test 'MAL-signatures` in direc
[ "sql", "grow", "pattern sql.grow(tid:bat[:oid], X_0:any_1):int ",
"mvc_grow_wrap;", "Resize the tid column of a declared table." ]
[ "sql", "importTable", "unsafe pattern sql.importTable(sname:str,
tname:str, onclient:int, fname:str...):bat[:any]... ",
"mvc_bin_import_table_wrap;", "Import a table from the files (fname)" ]
[ "sql", "include", "pattern sql.include(fname:str):void ",
"SQLinclude;", "Compile and execute a sql statements on the file" ]
-[ "sql", "init", "pattern sql.init():void ", "SQLinitEnvironment;",
"Initialize the environment for MAL" ]
[ "sql", "lag", "pattern sql.lag(b:any_1, l:any_2, d:any_1, p:any_3,
o:any_4):any_1 ", "SQLlag;", "return the value in the previous 'l' row in
the partition or 'd' if non existent" ]
[ "sql", "lag", "pattern sql.lag(b:any_1, l:any_2, d:bat[:any_1],
p:any_3, o:any_4):any_1 ", "SQLlag;", "return the value in the previous
'l' row in the partition or 'd' if non existent" ]
[ "sql", "lag", "pattern sql.lag(b:any_1, l:any_2, p:any_3,
o:any_4):any_1 ", "SQLlag;", "return the value in the previous 'l' row
in the partition or NULL if non existent" ]
@@ -16221,8 +16220,6 @@ stdout of test 'MAL-signatures` in direc
[ "sql", "single", "pattern sql.single(x:any_2):bat[:any_2] ",
"CMDBATsingle;", "" ]
[ "sql", "sql_environment", "inline function sql.sql_environment()
(name:bat[:str], value:bat[:str]);", "", "" ]
[ "sql", "sql_variables", "pattern sql.sql_variables():bat[:str]
", "sql_variables;", "return the table with session variables"
]
-[ "sql", "start", "pattern sql.start():void ", "SQLsession;",
"Switch to processing SQL statements" ]
-[ "sql", "start2", "pattern sql.start2():void ", "SQLsession2;",
"Switch to processing precompiled sql statements" ]
[ "sql", "storage", "pattern sql.storage() (schema:bat[:str],
table:bat[:str], column:bat[:str], type:bat[:str], mode:bat[:str],
location:bat[:str], count:bat[:lng], atomwidth:bat[:int], columnsize:bat[:lng],
heap:bat[:lng], hashes:bat[:lng], phash:bat[:bit], imprints:bat[:lng],
sorted:bat[:bit], revsorted:bat[:bit], key:bat[:bit], orderidx:bat[:lng]) ",
"sql_storage;", "return a table with storage information " ]
[ "sql", "storage", "pattern sql.storage(sname:str)
(schema:bat[:str], table:bat[:str], column:bat[:str], type:bat[:str],
mode:bat[:str], location:bat[:str], count:bat[:lng], atomwidth:bat[:int],
columnsize:bat[:lng], heap:bat[:lng], hashes:bat[:lng], phash:bat[:bit],
imprints:bat[:lng], sorted:bat[:bit], revsorted:bat[:bit], key:bat[:bit],
orderidx:bat[:lng]) ", "sql_storage;", "return a table with storage
information for a particular schema " ]
[ "sql", "storage", "pattern sql.storage(sname:str, tname:str)
(schema:bat[:str], table:bat[:str], column:bat[:str], type:bat[:str],
mode:bat[:str], location:bat[:str], count:bat[:lng], atomwidth:bat[:int],
columnsize:bat[:lng], heap:bat[:lng], hashes:bat[:lng], phash:bat[:bit],
imprints:bat[:lng], sorted:bat[:bit], revsorted:bat[:bit], key:bat[:bit],
orderidx:bat[:lng]) ", "sql_storage;", "return a table with storage
information for a particular table" ]
diff --git a/sql/backends/monet5/Tests/simpleSQL.malC
b/sql/backends/monet5/Tests/simpleSQL.malC
--- a/sql/backends/monet5/Tests/simpleSQL.malC
+++ b/sql/backends/monet5/Tests/simpleSQL.malC
@@ -1,6 +1,5 @@
#execute simple SQL queries from MAL
function foo();
-sql.init();
sql.eval("select 1;",true);
sql.eval("create table simpleT(i integer);");
diff --git a/sql/backends/monet5/Tests/simpleSQL.stable.out
b/sql/backends/monet5/Tests/simpleSQL.stable.out
--- a/sql/backends/monet5/Tests/simpleSQL.stable.out
+++ b/sql/backends/monet5/Tests/simpleSQL.stable.out
@@ -25,7 +25,6 @@ stdout of test 'simpleSQL` in directory
# 13:03:24 >
function user.foo():void;
- sql.init();
sql.eval("select 1;", true);
sql.eval("create table simpleT(i integer);");
sql.eval("insert into simpleT values(123);");
diff --git a/sql/backends/monet5/mal_backend.c
b/sql/backends/monet5/mal_backend.c
--- a/sql/backends/monet5/mal_backend.c
+++ b/sql/backends/monet5/mal_backend.c
@@ -34,7 +34,6 @@ backend_create(mvc *m, Client c)
if( b== NULL)
return NULL;
- b->console = isAdministrator(c);
b->mvc = m;
b->client = c;
b->mvc_var = 0;
diff --git a/sql/backends/monet5/mal_backend.h
b/sql/backends/monet5/mal_backend.h
--- a/sql/backends/monet5/mal_backend.h
+++ b/sql/backends/monet5/mal_backend.h
@@ -36,7 +36,6 @@ typedef enum output_format {
* generated or not */
typedef struct backend {
- bool console;
char language; /* 'S' or 's' or 'X' */
char depth;
bool first_statement_generated;
diff --git a/sql/backends/monet5/sql.mal b/sql/backends/monet5/sql.mal
--- a/sql/backends/monet5/sql.mal
+++ b/sql/backends/monet5/sql.mal
@@ -7,18 +7,6 @@
module batsql;
module sql;
-pattern start():void
-address SQLsession
-comment "Switch to processing SQL statements";
-
-pattern start2():void
-address SQLsession2
-comment "Switch to processing precompiled sql statements";
-
-pattern init():void
-address SQLinitEnvironment
-comment "Initialize the environment for MAL";
-
pattern shutdown(delay:bte, force:bit):str
address SQLshutdown_wrap;
pattern shutdown(delay:sht, force:bit):str
@@ -51,7 +39,6 @@ pattern abort()
address SQLabort
comment "Trigger the abort operation for a MAL block";
-
pattern eval(cmd:str):void
address SQLstatement
comment "Compile and execute a single sql statement";
diff --git a/sql/backends/monet5/sql_scenario.c
b/sql/backends/monet5/sql_scenario.c
--- a/sql/backends/monet5/sql_scenario.c
+++ b/sql/backends/monet5/sql_scenario.c
@@ -83,52 +83,6 @@ monet5_freecode(int clientid, backend_co
#endif
}
-str
-SQLsession(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci)
-{
- str msg = MAL_SUCCEED;
- const char *logmsg;
- int cnt=0;
-
- (void) mb;
- (void) stk;
- (void) pci;
- if (SQLinitialized == 0)// && (msg = SQLprelude(NULL)) != MAL_SUCCEED)
- return msg;
- msg = setScenario(cntxt, "sql");
- // Wait for any recovery process to be finished
- do {
- MT_sleep_ms(1000);
- logmsg = GDKgetenv("recovery");
- if( logmsg== NULL && ++cnt == 5)
- throw(SQL,"SQLinit", "#WARNING server not ready,
recovery in progress\n");
- } while (logmsg == NULL);
- return msg;
-}
-
-str
-SQLsession2(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci)
-{
- str msg = MAL_SUCCEED;
- const char *logmsg;
- int cnt=0;
-
- (void) mb;
- (void) stk;
- (void) pci;
- if (SQLinitialized == 0)// && (msg = SQLprelude(NULL)) != MAL_SUCCEED)
- return msg;
- msg = setScenario(cntxt, "msql");
- // Wait for any recovery process to be finished
- do {
- MT_sleep_ms(1000);
- logmsg = GDKgetenv("recovery");
- if( logmsg== NULL && ++cnt == 5)
- throw(SQL,"SQLinit","#WARNING server not ready,
recovery in progress\n");
- } while (logmsg == NULL);
- return msg;
-}
-
static str SQLinit(Client c);
str
@@ -305,7 +259,7 @@ SQLprepareClient(Client c, int login)
mvc_destroy(m);
throw(SQL,"sql.initClient",SQLSTATE(HY001)
MAL_MALLOC_FAIL);
}
- if (isAdministrator(c) || strcmp(c->scenario, "msql") == 0)
/* console should return everything */
+ if (strcmp(c->scenario, "msql") == 0)
m->reply_size = -1;
be = (void *) backend_create(m, c);
if( be == NULL) {
@@ -323,7 +277,6 @@ SQLprepareClient(Client c, int login)
if (m->session->tr)
reset_functions(m->session->tr);
if (login) {
- /* pass through credentials of the user if not console */
schema = monet5_user_set_def_schema(m, c->user);
if (!schema) {
_DELETE(schema);
@@ -339,7 +292,6 @@ SQLprepareClient(Client c, int login)
c->state[MAL_SCENARIO_PARSER] = c;
c->state[MAL_SCENARIO_OPTIMIZE] = c;
c->sqlcontext = be;
-
return NULL;
}
@@ -736,24 +688,6 @@ SQLexitClient(Client c)
return MAL_SUCCEED;
}
-/*
- * A statement received internally is simply appended for
- * execution
- */
-str
-SQLinitEnvironment(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci)
-{
- str err;
-
- (void) mb;
- (void) stk;
- (void) pci;
- if ((err = SQLinitClient(cntxt)) == MAL_SUCCEED)
- cntxt->phase[MAL_SCENARIO_EXITCLIENT] = SQLexitClient;
- return err;
-}
-
-
str
SQLstatement(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci)
{
@@ -874,7 +808,7 @@ SQLreader(Client c)
return MAL_SUCCEED;
}
#ifdef _SQL_READER_DEBUG
- fprintf(stderr, "#SQLparser: start reading SQL %s %s\n", (be->console ?
" from console" : ""), (blocked ? "Blocked read" : ""));
+ fprintf(stderr, "#SQLparser: start reading SQL %s\n", (blocked ?
"Blocked read" : ""));
#endif
language = be->language; /* 'S' for SQL, 'D' from debugger */
m = be->mvc;
@@ -886,9 +820,6 @@ SQLreader(Client c)
#ifdef _SQL_READER_DEBUG
fprintf(stderr, "#pos %d len %d eof %d \n", in->pos, in->len, in->eof);
#endif
- /*
- * Distinguish between console reading and mclient connections.
- */
while (more) {
more = false;
@@ -920,7 +851,7 @@ SQLreader(Client c)
c->yycur = 0;
}
if (in->eof || !blocked) {
- language = (be->console) ? 'S' : 0;
+ language = 0;
/* The rules of auto_commit require us to finish
and start a transaction on the start of a
new statement (s A;B; case) */
@@ -946,7 +877,7 @@ SQLreader(Client c)
if (be->language == 'D' && !in->eof)
return msg;
- if (rd == 0 && language !=0 && in->eof &&
!be->console) {
+ if (rd == 0 && language !=0 && in->eof) {
/* we hadn't seen the EOF before, so
just try again
(this time with prompt) */
more = true;
@@ -954,7 +885,7 @@ SQLreader(Client c)
}
go = false;
break;
- } else if (go && !be->console && language == 0) {
+ } else if (go && language == 0) {
if (in->buf[in->pos] == 's' && !in->eof) {
while ((rd = bstream_next(in)) > 0)
;
diff --git a/sql/backends/monet5/sql_scenario.h
b/sql/backends/monet5/sql_scenario.h
--- a/sql/backends/monet5/sql_scenario.h
+++ b/sql/backends/monet5/sql_scenario.h
@@ -15,10 +15,7 @@
/* #define _SQL_PARSER_DEBUG */
sql5_export int SQLdebug;
-sql5_export str SQLsession(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr
pci);
-sql5_export str SQLsession2(Client cntxt, MalBlkPtr mb, MalStkPtr stk,
InstrPtr pci);
sql5_export str SQLprelude(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr
pci);
-//sql5_export str SQLprelude(void *ret);
sql5_export str SQLepilogue(void *ret);
sql5_export str SQLautocommit(mvc *m);
@@ -40,7 +37,6 @@ sql5_export str handle_error(mvc *m, int
sql5_export str SQLassertHge(Client cntxt, MalBlkPtr mb, MalStkPtr stk,
InstrPtr pci);
#endif
-sql5_export str SQLinitEnvironment(Client cntxt, MalBlkPtr mb, MalStkPtr stk,
InstrPtr pci);
sql5_export str SQLstatement(Client cntxt, MalBlkPtr mb, MalStkPtr stk,
InstrPtr pci);
sql5_export str SQLcompile(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr
pci);
sql5_export str SQLinclude(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr
pci);
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
