Changeset: d44adc105272 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=d44adc105272
Modified Files:
monetdb5/modules/mal/mal_mapi.c
monetdb5/modules/mal/wlc.c
sql/backends/monet5/sql_scenario.c
sql/backends/monet5/wlr.c
Branch: Apr2019
Log Message:
No need for GDKregister (now deprecated): it's the same as using detached
thread.
diffs (71 lines):
diff --git a/monetdb5/modules/mal/mal_mapi.c b/monetdb5/modules/mal/mal_mapi.c
--- a/monetdb5/modules/mal/mal_mapi.c
+++ b/monetdb5/modules/mal/mal_mapi.c
@@ -840,7 +840,7 @@ SERVERlisten(int *Port, str *Usockfile,
#endif
psock[2] = INVALID_SOCKET;
if (MT_create_thread(&pid, (void (*)(void *)) SERVERlistenThread, psock,
- MT_THR_JOINABLE,
"listenThread") != 0) {
+ MT_THR_DETACHED,
"listenThread") != 0) {
if (sock != INVALID_SOCKET)
closesocket(sock);
#ifdef HAVE_SYS_UN_H
@@ -852,7 +852,6 @@ SERVERlisten(int *Port, str *Usockfile,
GDKfree(usockfile);
throw(MAL, "mal_mapi.listen", OPERATION_FAILED ": starting
thread failed");
}
- GDKregister(pid);
#ifdef DEBUG_SERVER
gethostname(host, (int) 512);
snprintf(msg, (int) 512, "#Ready to accept connections on %s:%d\n",
host, port);
diff --git a/monetdb5/modules/mal/wlc.c b/monetdb5/modules/mal/wlc.c
--- a/monetdb5/modules/mal/wlc.c
+++ b/monetdb5/modules/mal/wlc.c
@@ -349,10 +349,9 @@ WLCinit(void)
if( msg)
GDKerror("%s",msg);
if (MT_create_thread(&wlc_logger, WLClogger , (void*) 0,
- MT_THR_JOINABLE,
"WLClogger") < 0) {
+ MT_THR_DETACHED,
"WLClogger") < 0) {
GDKerror("wlc.logger thread could not be spawned");
}
- GDKregister(wlc_logger);
}
return MAL_SUCCEED;
}
diff --git a/sql/backends/monet5/sql_scenario.c
b/sql/backends/monet5/sql_scenario.c
--- a/sql/backends/monet5/sql_scenario.c
+++ b/sql/backends/monet5/sql_scenario.c
@@ -578,15 +578,13 @@ SQLinit(Client c)
if (msg != MAL_SUCCEED)
return msg;
- if ((sqllogthread = THRcreate((void (*)(void *)) mvc_logmanager, NULL,
MT_THR_JOINABLE, "logmanager")) == 0) {
+ if ((sqllogthread = THRcreate((void (*)(void *)) mvc_logmanager, NULL,
MT_THR_DETACHED, "logmanager")) == 0) {
throw(SQL, "SQLinit", SQLSTATE(42000) "Starting log manager
failed");
}
- GDKregister(sqllogthread);
if (!(SQLdebug&1024)) {
- if ((idlethread = THRcreate((void (*)(void *)) mvc_idlemanager,
NULL, MT_THR_JOINABLE, "idlemanager")) == 0) {
+ if ((idlethread = THRcreate((void (*)(void *)) mvc_idlemanager,
NULL, MT_THR_DETACHED, "idlemanager")) == 0) {
throw(SQL, "SQLinit", SQLSTATE(42000) "Starting idle
manager failed");
}
- GDKregister(idlethread);
}
return WLCinit();
}
diff --git a/sql/backends/monet5/wlr.c b/sql/backends/monet5/wlr.c
--- a/sql/backends/monet5/wlr.c
+++ b/sql/backends/monet5/wlr.c
@@ -443,10 +443,9 @@ WLRinit(void)
return MAL_SUCCEED;
// time to continue the consolidation process in the background
if (MT_create_thread(&wlr_thread, WLRprocessScheduler, (void*) cntxt,
- MT_THR_JOINABLE, "WLRprocessScheduler") < 0) {
+ MT_THR_DETACHED, "WLRprocessScheduler") < 0) {
throw(SQL,"wlr.init",SQLSTATE(42000) "Starting wlr
manager failed");
}
- GDKregister(wlr_thread);
return MAL_SUCCEED;
}
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
