Changeset: b9d6efd844ae for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=b9d6efd844ae
Modified Files:
sql/server/rel_unnest.c
sql/test/analytics/Tests/analytics01.stable.out
Branch: default
Log Message:
Use exp_match instead of exp_equal at rewrite_rank for more strict comparisons
diffs (truncated from 330 to 300 lines):
diff --git a/sql/server/rel_unnest.c b/sql/server/rel_unnest.c
--- a/sql/server/rel_unnest.c
+++ b/sql/server/rel_unnest.c
@@ -1805,7 +1805,7 @@ rewrite_rank(mvc *sql, sql_rel *rel, sql
for(node *nn = gbe->h ; nn && !found ; nn =
nn->next) {
sql_exp *e2 = nn->data;
/* the partition expression order
should be the same as the one in the order by clause (if it's in there as well)
*/
- if (!exp_equal(e1, e2)) {
+ if (exp_match(e1, e2)) {
if (is_ascending(e1))
set_ascending(e2);
else
diff --git a/sql/test/analytics/Tests/analytics01.stable.out
b/sql/test/analytics/Tests/analytics01.stable.out
--- a/sql/test/analytics/Tests/analytics01.stable.out
+++ b/sql/test/analytics/Tests/analytics01.stable.out
@@ -1453,7 +1453,7 @@ stdout of test 'analytics01` in director
[ 1 ]
[ NULL ]
#select percent_rank() over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% double # type
% 24 # length
@@ -1468,7 +1468,7 @@ stdout of test 'analytics01` in director
[ 0 ]
[ 0 ]
#select cume_dist() over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% double # type
% 24 # length
@@ -1483,7 +1483,7 @@ stdout of test 'analytics01` in director
[ 1 ]
[ 1 ]
#select ntile(1) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% tinyint # type
% 1 # length
@@ -1498,7 +1498,7 @@ stdout of test 'analytics01` in director
[ 1 ]
[ 1 ]
#select ntile(2) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% tinyint # type
% 1 # length
@@ -1513,7 +1513,7 @@ stdout of test 'analytics01` in director
[ 2 ]
[ 2 ]
#select ntile(5) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% tinyint # type
% 1 # length
@@ -1528,7 +1528,7 @@ stdout of test 'analytics01` in director
[ 5 ]
[ 5 ]
#select ntile(11) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% tinyint # type
% 2 # length
@@ -1543,7 +1543,7 @@ stdout of test 'analytics01` in director
[ 9 ]
[ 10 ]
#select ntile(100) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% tinyint # type
% 2 # length
@@ -1558,7 +1558,7 @@ stdout of test 'analytics01` in director
[ 9 ]
[ 10 ]
#select first_value(aa) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 2 # length
@@ -1573,7 +1573,7 @@ stdout of test 'analytics01` in director
[ 15 ]
[ 15 ]
#select first_value(bb) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1588,7 +1588,7 @@ stdout of test 'analytics01` in director
[ 3 ]
[ 3 ]
#select last_value(aa) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1603,7 +1603,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select last_value(bb) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1618,7 +1618,7 @@ stdout of test 'analytics01` in director
[ 4 ]
[ 4 ]
#select nth_value(aa, 2) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1633,7 +1633,7 @@ stdout of test 'analytics01` in director
[ 3 ]
[ 3 ]
#select nth_value(bb, 1) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1648,7 +1648,7 @@ stdout of test 'analytics01` in director
[ 3 ]
[ 3 ]
#select nth_value(bb, 1000) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1663,7 +1663,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lag(aa) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 2 # length
@@ -1678,7 +1678,7 @@ stdout of test 'analytics01` in director
[ 6 ]
[ 8 ]
#select lead(bb) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1693,7 +1693,7 @@ stdout of test 'analytics01` in director
[ 4 ]
[ NULL ]
#select lag(aa) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 2 # length
@@ -1708,7 +1708,7 @@ stdout of test 'analytics01` in director
[ 6 ]
[ 8 ]
#select lead(bb) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
% %1 # name
% int # type
% 1 # length
@@ -1723,7 +1723,7 @@ stdout of test 'analytics01` in director
[ 4 ]
[ NULL ]
#select ntile(null) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% tinyint # type
% 1 # length
@@ -1738,7 +1738,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select first_value(null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1753,7 +1753,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select last_value(null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1768,7 +1768,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select nth_value(null, 1) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1783,7 +1783,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select nth_value(aa, null) over () from analytics;
-% sys.%2 # table_name
+% sys. # table_name
% %2 # name
% int # type
% 1 # length
@@ -1798,7 +1798,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select nth_value(1, null) over () from analytics;
-% .%2 # table_name
+% . # table_name
% %2 # name
% tinyint # type
% 1 # length
@@ -1813,7 +1813,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select nth_value(null, null) over () from analytics;
-% .%2 # table_name
+% . # table_name
% %2 # name
% char # type
% 0 # length
@@ -1828,7 +1828,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lag(null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1843,7 +1843,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lag(null, null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1858,7 +1858,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lag(null, null, null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1873,7 +1873,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lead(null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1888,7 +1888,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lead(null, null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -1903,7 +1903,7 @@ stdout of test 'analytics01` in director
[ NULL ]
[ NULL ]
#select lead(null, null, null) over () from analytics;
-% .%1 # table_name
+% . # table_name
% %1 # name
% char # type
% 0 # length
@@ -2776,7 +2776,7 @@ stdout of test 'analytics01` in director
[ 6, 3, 100, 100 ]
[ NULL, 4, 100, 100 ]
#select nth_value(aa, aa) over () from analytics;
-% sys.%1 # table_name
+% sys. # table_name
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list
