MonetDB: Jun2020 - Some niggles from coverity.

[Sjoerd Mullender]

Changeset: fd9fc4dda930 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=fd9fc4dda930
Modified Files:
        clients/mapiclient/mclient.c
        sql/storage/bat/bat_table.c
Branch: Jun2020
Log Message:

Some niggles from coverity.


diffs (28 lines):

diff --git a/clients/mapiclient/mclient.c b/clients/mapiclient/mclient.c
--- a/clients/mapiclient/mclient.c
+++ b/clients/mapiclient/mclient.c
@@ -3061,7 +3061,8 @@ getfile(void *data, const char *filename
                priv->f = NULL;
                return s < 0 ? "error reading file" : NULL;
        }
-       *size = (size_t) s;
+       if (size)
+               *size = (size_t) s;
        return buf;
 }
 
diff --git a/sql/storage/bat/bat_table.c b/sql/storage/bat/bat_table.c
--- a/sql/storage/bat/bat_table.c
+++ b/sql/storage/bat/bat_table.c
@@ -251,8 +251,10 @@ table_insert(sql_trans *tr, sql_table *t
                if (!val)
                        break;
                ok = store_funcs.append_col(tr, c, val, 
c->type.type->localtype);
-               if (ok != LOG_OK)
+               if (ok != LOG_OK) {
+                       va_end(va);
                        return ok;
+               }
                cnt++;
        }
        va_end(va);
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list