MonetDB: default - fixed fd leak

[Niels Nes]

Changeset: 00dd71f55852 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=00dd71f55852
Modified Files:
        common/utils/msabaoth.c
Branch: default
Log Message:

fixed fd leak


diffs (23 lines):

diff --git a/common/utils/msabaoth.c b/common/utils/msabaoth.c
--- a/common/utils/msabaoth.c
+++ b/common/utils/msabaoth.c
@@ -858,8 +858,10 @@ msab_getSingleStatus(const char *pathbuf
                snprintf(buf, sizeof(buf), "%s/%s/%s", pathbuf, dbname, 
SECRETFILE);
                if ((f = fopen(buf, "r")) == NULL)
                        break;
-               if (fstat(fileno(f), &stb) < 0)
+               if (fstat(fileno(f), &stb) < 0) {
+                       fclose(f);
                        break;
+               }
                size_t len = (size_t)stb.st_size;
                char *secret = malloc(len + 1);
                if (!secret) {
@@ -871,6 +873,7 @@ msab_getSingleStatus(const char *pathbuf
                        free(secret);
                        break;
                }
+               fclose(f);
                secret[len] = '\0';
                sdb->secret = secret;
        } while (0);
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list