MonetDB: Oct2020 - removed get_table from interface, wasn't usefull

[Niels Nes]

Changeset: 68b52437c72c for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=68b52437c72c
Modified Files:
        tools/monetdbe/monetdbe.c
        tools/monetdbe/monetdbe.h
Branch: Oct2020
Log Message:

removed get_table from interface, wasn't usefull


diffs (82 lines):

diff --git a/tools/monetdbe/monetdbe.c b/tools/monetdbe/monetdbe.c
--- a/tools/monetdbe/monetdbe.c
+++ b/tools/monetdbe/monetdbe.c
@@ -79,10 +79,6 @@ embedded_type(int t) {
        }
 }
 
-typedef struct monetdbe_table_t {
-       sql_table t;
-} monetdbe_table_t;
-
 typedef struct {
        Client c;
        char *msg;
@@ -925,46 +921,6 @@ monetdbe_cleanup_result(monetdbe_databas
 }
 
 char*
-monetdbe_get_table(monetdbe_database dbhdl, monetdbe_table** table, const 
char* schema_name, const char* table_name)
-{
-       monetdbe_database_internal *mdbe = (monetdbe_database_internal*)dbhdl;
-       mvc *m;
-       sql_schema *s;
-
-
-       if ((mdbe->msg = validate_database_handle(mdbe, 
"monetdbe.monetdbe_get_table")) != MAL_SUCCEED) {
-
-               return mdbe->msg;
-       }
-
-       if ((mdbe->msg = getSQLContext(mdbe->c, NULL, &m, NULL)) != NULL)
-               goto cleanup;
-       if ((mdbe->msg = SQLtrans(m)) != MAL_SUCCEED)
-               goto cleanup;
-       if (!table) {
-               mdbe->msg = createException(MAL, "monetdbe.monetdbe_get_table", 
"Parameter table is NULL");
-               goto cleanup;
-       }
-       if (schema_name) {
-               if (!(s = mvc_bind_schema(m, schema_name))) {
-                       mdbe->msg = createException(MAL, 
"monetdbe.monetdbe_get_table", "Could not find schema %s", schema_name);
-                       goto cleanup;
-               }
-       } else {
-               s = cur_schema(m);
-       }
-       if (!(*(sql_table**)table = mvc_bind_table(m, s, table_name))) {
-               mdbe->msg = createException(MAL, "monetdbe.monetdbe_get_table", 
"Could not find table %s", table_name);
-               goto cleanup;
-       }
-
-cleanup:
-       mdbe->msg = commit_action(m, mdbe, NULL, NULL);
-
-       return mdbe->msg;
-}
-
-char*
 monetdbe_get_columns(monetdbe_database dbhdl, const char* schema_name, const 
char *table_name, size_t *column_count,
                                        char ***column_names, int 
**column_types)
 {
diff --git a/tools/monetdbe/monetdbe.h b/tools/monetdbe/monetdbe.h
--- a/tools/monetdbe/monetdbe.h
+++ b/tools/monetdbe/monetdbe.h
@@ -72,9 +72,6 @@ typedef struct {
        char* name;
 } monetdbe_column;
 
-struct monetdbe_table_t;
-typedef struct monetdbe_table_t monetdbe_table;
-
 typedef struct {
        size_t nparam;
        monetdbe_types  *type;
@@ -151,7 +148,6 @@ monetdbe_export char* monetdbe_cleanup_s
 monetdbe_export char* monetdbe_append(monetdbe_database dbhdl, const char* 
schema, const char* table, monetdbe_column **input, size_t column_count);
 monetdbe_export const void* monetdbe_null(monetdbe_database dbhdl, 
monetdbe_types t);
 
-monetdbe_export char* monetdbe_get_table(monetdbe_database dbhdl, 
monetdbe_table** table, const char* schema_name, const char* table_name);
 monetdbe_export char* monetdbe_get_columns(monetdbe_database dbhdl, const 
char* schema_name, const char *table_name, size_t *column_count, char 
***column_names, int **column_types);
 
 monetdbe_export char* monetdbe_dump_database(monetdbe_database dbhdl, const 
char *backupfile);
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list