Changeset: 0f6732e8521c for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=0f6732e8521c
Modified Files:
sql/server/rel_schema.c
Branch: scoping2
Log Message:
Cannot comment on declared tables
diffs (26 lines):
diff --git a/sql/server/rel_schema.c b/sql/server/rel_schema.c
--- a/sql/server/rel_schema.c
+++ b/sql/server/rel_schema.c
@@ -1928,6 +1928,10 @@ rel_find_designated_table(mvc *sql, symb
sname = qname_schema(qname);
tname = qname_schema_object(qname);
t = find_table_or_view_on_scope(sql, NULL, sname, tname, "COMMENT ON",
!want_table);
+ if (t && isDeclaredTable(t)) {
+ sql_error(sql, 02, SQLSTATE(42000) "COMMENT ON declared table
not allowed");
+ return 0;
+ }
if (t && t->s && isTempSchema(t->s)) {
sql_error(sql, 02, SQLSTATE(42000) "COMMENT ON tmp object not
allowed");
return 0;
@@ -1965,7 +1969,10 @@ rel_find_designated_column(mvc *sql, sym
assert(colname->h->next->next->type == type_string);
cname = colname->h->next->next->data.sval;
}
- if (!(t = find_table_or_view_on_scope(sql, NULL, sname, tname, "COMMENT
ON", false))) {
+ if (!(t = find_table_or_view_on_scope(sql, NULL, sname, tname, "COMMENT
ON", false)))
+ return 0;
+ if (t && isDeclaredTable(t)) {
+ sql_error(sql, 02, SQLSTATE(42000) "COMMENT ON declared table
not allowed");
return 0;
}
if (t && t->s && isTempSchema(t->s)) {
_______________________________________________
checkin-list mailing list
[email protected]
https://www.monetdb.org/mailman/listinfo/checkin-list