Changeset: 264d4186fdcd for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/264d4186fdcd
Modified Files:
        clients/odbc/driver/SQLGetInfo.c
        clients/odbc/samples/testgetinfo.c
Branch: default
Log Message:

Ask the server which keywords it knows (from sys.keywords).


diffs (140 lines):

diff --git a/clients/odbc/driver/SQLGetInfo.c b/clients/odbc/driver/SQLGetInfo.c
--- a/clients/odbc/driver/SQLGetInfo.c
+++ b/clients/odbc/driver/SQLGetInfo.c
@@ -41,13 +41,15 @@ MNDBGetInfo(ODBCDbc *dbc,
        char buf[64];
        const char *sValue = NULL;      /* iff non-NULL, return string value */
        int len = sizeof(SQLUINTEGER);  /* most common size to return */
+       MapiHdl hdl = NULL;
 
        /* For some info types an active connection is needed */
        if (!dbc->Connected &&
            (InfoType == SQL_DATA_SOURCE_NAME ||
             InfoType == SQL_SERVER_NAME ||
             InfoType == SQL_DATABASE_NAME ||
-            InfoType == SQL_USER_NAME)) {
+            InfoType == SQL_USER_NAME ||
+            InfoType == SQL_KEYWORDS)) {
                /* Connection does not exist */
                addDbcError(dbc, "08003", NULL, 0);
                return SQL_ERROR;
@@ -658,39 +660,13 @@ MNDBGetInfo(ODBCDbc *dbc,
                 * SQL_CA2_SIMULATE_UNIQUE */
                break;
        case SQL_KEYWORDS:
-               /* Returns the MonetDB keywords which are not listed
-                * as ODBC keyword in the #define SQL_ODBC_KEYWORDS in
-                * sql.h, collated from
-                * sql_scan.c:scanner_init_keywords with values
-                * removed that are in
-                * sql_parser.y:non_reserved_word */
-               sValue = "ADD,ADMIN,AFTER,AGGREGATE,ALL,ALTER,ALWAYS,AND,ANY,"
-                       "ASYMMETRIC,ATOMIC,AUTO_INCREMENT,BEFORE,BEST,BIGINT,"
-                       "BIGSERIAL,BINARY,BLOB,CALL,CHAIN,CLOB,COMMITTED,COPY,"
-                       "CUME_DIST,CURRENT_ROLE,DELIMITERS,DENSE_RANK,DO,"
-                       "EACH,EFFORT,ELSEIF,ENCRYPTED,EVERY,EXCLUDE,FOLLOWING,"
-                       "FUNCTION,FWF,GENERATED,GEOMETRYCOLLECTION,"
-                       "GEOMETRYCOLLECTIONM,GEOMETRYCOLLECTIONZ,"
-                       "GEOMETRYCOLLECTIONZM,HUGEINT,IF,ILIKE,"
-                       "LATERAL,LIMIT,LINESTRING,LINESTRINGM,"
-                       "LINESTRINGZ,LINESTRINGZM,LOADER,LOCALTIME,"
-                       "LOCALTIMESTAMP,LOCKED,MEDIUMINT,MERGE,"
-                       "MULTILINESTRING,MULTILINESTRINGM,MULTILINESTRINGZ,"
-                       "MULTILINESTRINGZM,MULTIPOINT,MULTIPOINTM,MULTIPOINTZ,"
-                       "MULTIPOINTZM,MULTIPOLYGON,MULTIPOLYGONM,"
-                       "MULTIPOLYGONZ,MULTIPOLYGONZM,NEW,NOCYCLE,NOMAXVALUE,"
-                       "NOMINVALUE,NOW,OFFSET,OLD,ORDERED,OTHERS,OVER,"
-                       "PARTITION,PERCENT_RANK,POINT,POINTM,POINTZ,POINTZM,"
-                       "POLYGON,POLYGONM,POLYGONZ,POLYGONZM,PRECEDING,"
-                       "RANGE,RANK,RECORDS,REFERENCING,REMOTE,"
-                       "RENAME,REPEATABLE,REPLICA,RESTART,RETURN,RETURNS,"
-                       "ROW_NUMBER,SAMPLE,SAVEPOINT,SEQUENCE,SERIAL,"
-                       "SERIALIZABLE,SIMPLE,SPLIT_PART,STDIN,STDOUT,STREAM,"
-                       "STRING,SYMMETRIC,TIES,TINYINT,TRIGGER,TRUNCATE,"
-                       
"UNBOUNDED,UNCOMMITTED,UNENCRYPTED,UNLOGGED,WHILE,WINDOW,XMLAGG,"
-                       "XMLATTRIBUTES,XMLCOMMENT,XMLCONCAT,XMLDOCUMENT,"
-                       "XMLELEMENT,XMLFOREST,XMLNAMESPACES,XMLPARSE,XMLPI,"
-                       "XMLQUERY,XMLSCHEMA,XMLTEXT,XMLVALIDATE";
+               /* Returns the MonetDB keywords, i.e. a dump of
+                * sys.keywords */
+               if ((hdl = mapi_query(dbc->mid, "WITH x(k) AS (SELECT keyword 
FROM sys.keywords ORDER BY keyword) SELECT group_concat(k, ',') FROM x")) != 
NULL && mapi_fetch_row(hdl)) {
+                       sValue = mapi_fetch_field(hdl, 0);
+               } else {
+                       addDbcError(dbc, mapi_error(dbc->mid) == MTIMEOUT ? 
"HYT01" : "HY000", NULL, 0);
+               }
                break;
        case SQL_LIKE_ESCAPE_CLAUSE:
                sValue = "Y";   /* "N" */
@@ -1194,6 +1170,9 @@ MNDBGetInfo(ODBCDbc *dbc,
                        *StringLengthPtr = len;
        }
 
+       if (hdl)
+               mapi_close_handle(hdl);
+
        return dbc->Error ? SQL_SUCCESS_WITH_INFO : SQL_SUCCESS;
 }
 
diff --git a/clients/odbc/samples/testgetinfo.c 
b/clients/odbc/samples/testgetinfo.c
--- a/clients/odbc/samples/testgetinfo.c
+++ b/clients/odbc/samples/testgetinfo.c
@@ -644,7 +644,49 @@ const struct {
                .info = SQL_KEYWORDS,
                .name = "SQL_KEYWORDS",
                .type = STRING,
-               .str = 
"ADD,ADMIN,AFTER,AGGREGATE,ALL,ALTER,ALWAYS,AND,ANY,ASYMMETRIC,ATOMIC,AUTO_INCREMENT,BEFORE,BEST,BIGINT,BIGSERIAL,BINARY,BLOB,CALL,CHAIN,CLOB,COMMITTED,COPY,CUME_DIST,CURRENT_ROLE,DELIMITERS,DENSE_RANK,DO,EACH,EFFORT,ELSEIF,ENCRYPTED,EVERY,EXCLUDE,FOLLOWING,FUNCTION,FWF,GENERATED,GEOMETRYCOLLECTION,GEOMETRYCOLLECTIONM,GEOMETRYCOLLECTIONZ,GEOMETRYCOLLECTIONZM,HUGEINT,IF,ILIKE,LATERAL,LIMIT,LINESTRING,LINESTRINGM,LINESTRINGZ,LINESTRINGZM,LOADER,LOCALTIME,LOCALTIMESTAMP,LOCKED,MEDIUMINT,MERGE,MULTILINESTRING,MULTILINESTRINGM,MULTILINESTRINGZ,MULTILINESTRINGZM,MULTIPOINT,MULTIPOINTM,MULTIPOINTZ,MULTIPOINTZM,MULTIPOLYGON,MULTIPOLYGONM,MULTIPOLYGONZ,MULTIPOLYGONZM,NEW,NOCYCLE,NOMAXVALUE,NOMINVALUE,NOW,OFFSET,OLD,ORDERED,OTHERS,OVER,PARTITION,PERCENT_RANK,POINT,POINTM,POINTZ,POINTZM,POLYGON,POLYGONM,POLYGONZ,POLYGONZM,PRECEDING,RANGE,RANK,RECORDS,REFERENCING,REMOTE,RENAME,REPEATABLE,REPLICA,RESTART,RETURN,RETURNS,ROW_NUMBER,SAMPLE,SAVEPOINT,SEQUENCE,SERIAL,SERIALIZABLE,SIMPLE,SPLI
 
T_PART,STDIN,STDOUT,STREAM,STRING,SYMMETRIC,TIES,TINYINT,TRIGGER,TRUNCATE,UNBOUNDED,UNCOMMITTED,UNENCRYPTED,UNLOGGED,WHILE,WINDOW,XMLAGG,XMLATTRIBUTES,XMLCOMMENT,XMLCONCAT,XMLDOCUMENT,XMLELEMENT,XMLFOREST,XMLNAMESPACES,XMLPARSE,XMLPI,XMLQUERY,XMLSCHEMA,XMLTEXT,XMLVALIDATE",
+               .str = "ADD,ADMIN,AFTER,AGGREGATE,ALL,ALTER,ALWAYS,ANALYZE,AND,"
+                       "ANY,ASC,ASYMMETRIC,AT,ATOMIC,AUTHORIZATION,"
+                       "AUTO_INCREMENT,BEFORE,BEGIN,BEST,BETWEEN,BIG,BIGINT,"
+                       "BIGSERIAL,BINARY,BLOB,BY,CACHE,CALL,CASCADE,CASE,CAST,"
+                       "CENTURY,CHAIN,CHAR,CHARACTER,CHECK,CLIENT,CLOB,"
+                       "COALESCE,COLUMN,COMMENT,COMMIT,COMMITTED,CONSTRAINT,"
+                       "CONTINUE,CONVERT,COPY,CORRESPONDING,CREATE,CROSS,CUBE,"
+                       "CURRENT,CURRENT_DATE,CURRENT_ROLE,CURRENT_SCHEMA,"
+                       "CURRENT_TIME,CURRENT_TIMESTAMP,CURRENT_TIMEZONE,"
+                       "CURRENT_USER,CYCLE,DATA,DATE,DAY,DEALLOCATE,DEBUG,DEC,"
+                       "DECADE,DECIMAL,DECLARE,DEFAULT,DELETE,DELIMITERS,DESC,"
+                       "DIAGNOSTICS,DISTINCT,DO,DOUBLE,DOW,DOY,DROP,EACH,"
+                       "EFFORT,ELSE,ELSEIF,ENCRYPTED,END,ENDIAN,EPOCH,ESCAPE,"
+                       "EVERY,EXCEPT,EXCLUDE,EXEC,EXECUTE,EXISTS,EXPLAIN,"
+                       "EXTERNAL,EXTRACT,FALSE,FIRST,FLOAT,FOLLOWING,FOR,"
+                       "FOREIGN,FROM,FULL,FUNCTION,FWF,GENERATED,GLOBAL,GRANT,"
+                       "GROUP,GROUPING,GROUPS,HAVING,HOUR,HUGEINT,IDENTITY,IF,"
+                       "ILIKE,IMPRINTS,IN,INCREMENT,INDEX,INNER,INSERT,INT,"
+                       "INTEGER,INTERSECT,INTERVAL,INTO,IS,ISOLATION,JOIN,KEY,"
+                       "LANGUAGE,LARGE,LAST,LATERAL,LEFT,LEVEL,LIKE,LIMIT,"
+                       "LITTLE,LOADER,LOCAL,LOCALTIME,LOCALTIMESTAMP,MATCH,"
+                       "MATCHED,MAXVALUE,MEDIUMINT,MERGE,MINUTE,MINVALUE,"
+                       "MONTH,NAME,NATIVE,NATURAL,NEW,NEXT,NO,NOT,NOW,NULL,"
+                       "NULLIF,NULLS,NUMERIC,OBJECT,OF,OFFSET,OLD,ON,ONLY,"
+                       "OPTION,OPTIONS,OR,ORDER,ORDERED,OTHERS,OUTER,OVER,"
+                       "PARTIAL,PARTITION,PASSWORD,PATH,PLAN,POSITION,"
+                       "PRECEDING,PRECISION,PREP,PREPARE,PRESERVE,PRIMARY,"
+                       "PRIVILEGES,PROCEDURE,PUBLIC,QUARTER,RANGE,READ,REAL,"
+                       "RECORDS,REFERENCES,REFERENCING,RELEASE,REMOTE,RENAME,"
+                       "REPEATABLE,REPLACE,REPLICA,RESTART,RESTRICT,RETURN,"
+                       "RETURNS,REVOKE,RIGHT,ROLE,ROLLBACK,ROLLUP,ROW,ROWS,"
+                       "SAMPLE,SAVEPOINT,SCHEMA,SECOND,SEED,SELECT,SEQUENCE,"
+                       "SERIAL,SERIALIZABLE,SERVER,SESSION,SESSION_USER,SET,"
+                       "SETS,SIMPLE,SIZE,SMALLINT,SOME,SPLIT_PART,START,"
+                       "STATEMENT,STDIN,STDOUT,STORAGE,STRING,SUBSTRING,"
+                       "SYMMETRIC,TABLE,TEMP,TEMPORARY,TEXT,THEN,TIES,TIME,"
+                       "TIMESTAMP,TINYINT,TO,TRACE,TRANSACTION,TRIGGER,TRUE,"
+                       "TRUNCATE,TYPE,UNBOUNDED,UNCOMMITTED,UNENCRYPTED,UNION,"
+                       "UNIQUE,UPDATE,USER,USING,VALUE,VALUES,VARCHAR,VARYING,"
+                       "VIEW,WEEK,WHEN,WHERE,WHILE,WINDOW,WITH,WORK,WRITE,"
+                       "XMLAGG,XMLATTRIBUTES,XMLCOMMENT,XMLCONCAT,XMLDOCUMENT,"
+                       "XMLELEMENT,XMLFOREST,XMLNAMESPACES,XMLPARSE,XMLPI,"
+                       "XMLQUERY,XMLSCHEMA,XMLTEXT,XMLVALIDATE,YEAR,ZONE",
        },
        {
                .info = SQL_LIKE_ESCAPE_CLAUSE,
@@ -1089,7 +1131,7 @@ main(int argc, char **argv)
        char *user = "monetdb";
        char *pass = "monetdb";
        SQLRETURN ret;
-       char str[2048];
+       char str[4096];
        SQLSMALLINT resultlen;
        SQLUSMALLINT s;
        SQLUINTEGER i;
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to