Changeset: 20acc7b01f57 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/20acc7b01f57
Modified Files:
        sql/backends/monet5/rel_bin.c
        sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
Branch: default
Log Message:

fixed issue #7482, with global group by's there is an empty sub expression list


diffs (22 lines):

diff --git a/sql/backends/monet5/rel_bin.c b/sql/backends/monet5/rel_bin.c
--- a/sql/backends/monet5/rel_bin.c
+++ b/sql/backends/monet5/rel_bin.c
@@ -1713,7 +1713,7 @@ exp_bin(backend *be, sql_exp *e, stmt *l
                           and/or an attribute to count */
                        if (grp) {
                                as = grp;
-                       } else if (left) {
+                       } else if (left && !list_empty(left->op4.lval)) {
                                as = bin_find_smallest_column(be, left);
                                as = exp_count_no_nil_arg(e, ext, NULL, as);
                        } else {
diff --git 
a/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test 
b/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
--- a/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
+++ b/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
@@ -1,5 +1,5 @@
-skipif knownfail
 query I nosort
 SELECT var_samp ( '12' ) OVER ( ORDER BY CAST ( ( CASE WHEN ( 99 ) THEN COUNT 
( * ) ELSE CASE WHEN 1 THEN ( FALSE ) END END ) AS BIGINT ) )
 ----
+0
 
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org

Reply via email to