MonetDB: json-extend - Update more TOOD's

[Yunus Koning via checkin-list]

Changeset: 6e5c067600f6 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/6e5c067600f6
Modified Files:
        monetdb5/modules/atoms/pg_jsonpath/jsonpath_exec.c
        monetdb5/modules/atoms/pg_jsonpath/jsonpath_gram.y
        monetdb5/modules/atoms/pg_jsonpath/postgres_defines.h
Branch: json-extend
Log Message:

Update more TOOD's


diffs (53 lines):

diff --git a/monetdb5/modules/atoms/pg_jsonpath/jsonpath_exec.c 
b/monetdb5/modules/atoms/pg_jsonpath/jsonpath_exec.c
--- a/monetdb5/modules/atoms/pg_jsonpath/jsonpath_exec.c
+++ b/monetdb5/modules/atoms/pg_jsonpath/jsonpath_exec.c
@@ -837,7 +837,6 @@ executeItemOptUnwrapTarget(JsonPathExecC
                case jpiTimestamp:
                case jpiTimestampTz:
                        assert (0);
-                       // TODO: remove datetime functionality
                        return jperError;
 
                case jpiKeyValue:
@@ -1583,7 +1582,7 @@ Numeric yyjson2Numeric(JsonbValue* val) 
        return num;
 }
 
-static inline // TODO: replace Numeric with yyjson where possible
+static inline
 JsonbValue* Numeric2yyjson(JsonPathExecContext *cxt, Numeric num) {
        yyjson_mut_val* mut_jbv;
 
@@ -2132,7 +2131,7 @@ compareItems(JsonPathExecContext *cxt, i
                case jbvDatetime:
                        {
                                (void) useTz;
-                               assert(0); // TODO not implemented
+                               assert(0);
                                return jpbUnknown;
                        }
                        break;
diff --git a/monetdb5/modules/atoms/pg_jsonpath/jsonpath_gram.y 
b/monetdb5/modules/atoms/pg_jsonpath/jsonpath_gram.y
--- a/monetdb5/modules/atoms/pg_jsonpath/jsonpath_gram.y
+++ b/monetdb5/modules/atoms/pg_jsonpath/jsonpath_gram.y
@@ -379,7 +379,7 @@ method:
 static JsonPathParseItem *
 makeItemType(JsonPathItemType type)
 {
-       JsonPathParseItem *v = palloc(sizeof(*v));
+       JsonPathParseItem *v = palloc(sizeof(*v)); // TODO: palloc should use 
the context allocator
 
        CHECK_FOR_INTERRUPTS();
 
diff --git a/monetdb5/modules/atoms/pg_jsonpath/postgres_defines.h 
b/monetdb5/modules/atoms/pg_jsonpath/postgres_defines.h
--- a/monetdb5/modules/atoms/pg_jsonpath/postgres_defines.h
+++ b/monetdb5/modules/atoms/pg_jsonpath/postgres_defines.h
@@ -38,7 +38,7 @@ enum jbvType
 };
 
 // postgres_ext.h
-typedef unsigned int Oid; // TODO: remove this type
+typedef unsigned int Oid;
 
 typedef struct {
        union {
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org