Changeset: b004c89b829c for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/b004c89b829c
Modified Files:
        sql/backends/monet5/sql_result.c
Branch: Mar2025
Log Message:

Update comment.


diffs (24 lines):

diff --git a/sql/backends/monet5/sql_result.c b/sql/backends/monet5/sql_result.c
--- a/sql/backends/monet5/sql_result.c
+++ b/sql/backends/monet5/sql_result.c
@@ -1666,7 +1666,11 @@ mvc_export_head(backend *b, stream *s, i
                return -4;
 
        /* row count, min(count, reply_size) */
-       /* the columnar protocol ignores the reply size by fetching the entire 
resultset at once, so don't set it */
+       /* the columnar protocol ignores the reply size by fetching the
+        * entire resultset at once, so don't set it; also, the MAPI
+        * protocol doesn't allow for retrieving rows using the Xexport*
+        * commands for Q_PREPARE results (due to an oversight), so we send
+        * it all in the first response */
        if (mvc_send_int(s, (b->client && b->client->protocol != 
PROTOCOL_COLUMNAR && m->reply_size >= 0 && (BUN) m->reply_size < count && 
t->query_type != Q_PREPARE) ? m->reply_size : (int) count) != 1)
                return -4;
 
@@ -1820,6 +1824,7 @@ mvc_export_result(backend *b, stream *s,
                return mvc_export_table_columnar(s, t, m->scanner.rs);
        }
 
+       /* for Q_PREPARE results, send everything */
        count = t->query_type == Q_PREPARE ? t->nr_rows : (BUN) m->reply_size;
        if (m->reply_size != -2 && (count <= 0 || count >= t->nr_rows)) {
                count = t->nr_rows;
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to