Changeset: 0a0df4dc54a8 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/0a0df4dc54a8
Modified Files:
        testing/Mtest.py.in
        testing/process.py
Branch: Mar2025
Log Message:

Backed out changeset 481cb577a1af.
I had tested it, and I'm pretty sure it worked, but it looks like it
doesn't after all.


diffs (113 lines):

diff --git a/testing/Mtest.py.in b/testing/Mtest.py.in
--- a/testing/Mtest.py.in
+++ b/testing/Mtest.py.in
@@ -1258,8 +1258,6 @@ def PerformDir(env, testdir, testlist, t
                     except:
                         pass
                     environ['MAPIPORT'] = pSrvr.port
-                    if pSrvr.usock is not None:
-                        environ['MAPIUSOCK'] = pSrvr.usock
                     SetExecEnv(env['exe'], pSrvr.port, verbosity > 1, environ)
                 if global_timeout and start_time + global_timeout < 
time.time():
                     if not testweb:
@@ -2887,7 +2885,6 @@ class ServerClass:
 
         port = None
         self.port = None
-        self.usock = None
         if self.pollfile:
             while True:
                 proc.poll()
@@ -2916,14 +2913,9 @@ class ServerClass:
                     return
                 time.sleep(0.1)
             with open(os.path.join(os.path.split(self.pollfile)[0], '.conn')) 
as fil:
-                connurls = fil.readlines()
-            for connurl in connurls:
-                connurl = connurl.strip()
-                res = mapiportre.search(connurl)
-                if res is not None:
-                    port = res.group('port')
-                elif 'monetdb:///' in connurl:
-                    self.usock = connurl
+                connurl = fil.read()
+            res = mapiportre.search(connurl)
+            port = res.group('port')
         else:
             loadedseen = False
             endtime = time.time() + 30
@@ -3138,7 +3130,7 @@ def DoIt(env, SERVER, CALL, TST, EXT, Te
                                         password=passwd or 'monetdb',
                                         hostname=HOST,
                                         port=int(pSrvr.port),
-                                        database=TSTDB if pSrvr.usock is None 
else pSrvr.usock,
+                                        database=TSTDB,
                                         language='sql',
                                         timeout=TIMEOUT,
                                         alltests=CONDITIONALS['KNOWNFAIL'])
@@ -3173,7 +3165,7 @@ def DoIt(env, SERVER, CALL, TST, EXT, Te
                                     password=passwd or 'monetdb',
                                     hostname=HOST,
                                     port=int(pSrvr.port),
-                                    database=TSTDB if pSrvr.usock is None else 
pSrvr.usock,
+                                    database=TSTDB,
                                     language=lang,
                                     timeout=TIMEOUT,
                                     alltests=CONDITIONALS['KNOWNFAIL'])
@@ -3210,8 +3202,6 @@ def DoIt(env, SERVER, CALL, TST, EXT, Te
                                 defines.append(f'TSTSRCBASE={TSTSRCBASE}')
                                 defines.append(f'TSTDB={TSTDB}')
                                 defines.append(f'MAPIPORT={pSrvr.port}')
-                                if pSrvr.usock is not None:
-                                    defines.append(f'MAPIUSOCK={pSrvr.usock}')
                             try:
                                 sql.parse(os.path.join(TSTTRGDIR, testfile), 
approve=open(os.path.join(TSTTRGDIR, TST+'.newtest'),'w') if approve else None, 
defines=defines)
                             except KeyboardInterrupt:
@@ -3254,11 +3244,9 @@ def DoIt(env, SERVER, CALL, TST, EXT, Te
                 for i in range(len(Clnt)):
                     Clnt[i] = Clnt[i].replace('${PORT}', pSrvr.port)
                 if user:
-                    Clnt.append(f'-u{user}')
+                    Clnt.append('-u%s' % user)
                 if passwd:
-                    Clnt.append(f'-P{passwd}')
-                if pSrvr.usock:
-                    Clnt.append(f'-d{pSrvr.usock}')
+                    Clnt.append('-P%s' % passwd)
                 for f in TSTs:
                     returncode = RunIt(Clnt, True, 
openutf8(os.path.join(TSTTRGDIR, f)), ClntOut, ClntErr, TIMEOUT, pSrvr, 
TSTTRGDIR, environ)
                     if returncode:
diff --git a/testing/process.py b/testing/process.py
--- a/testing/process.py
+++ b/testing/process.py
@@ -376,13 +376,10 @@ class client(Popen):
         # if server instance is specified, it provides defaults for
         # database name and port
         if server is not None:
-            if port is None and dbname is None and hasattr(server, 'usock') 
and server.usock is not None:
-                dbname = server.usock
-            else:
-                if port is None:
-                    port = server.dbport
-                if dbname is None:
-                    dbname = server.dbname
+            if port is None:
+                port = server.dbport
+            if dbname is None:
+                dbname = server.dbname
 
         if port is not None:
             for i in range(len(cmd)):
@@ -395,11 +392,7 @@ class client(Popen):
                 if port:
                     raise
         if dbname is None:
-            usock = os.getenv('MAPIUSOCK')
-            if usock is None:
-                dbname = os.getenv('TSTDB')
-            else:
-                dbname = usock
+            dbname = os.getenv('TSTDB')
         if dbname is not None and dbname:
             cmd.append('--database=%s' % dbname)
         if user is not None or passwd is not None:
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to