Changeset: 1fa520e35204 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/1fa520e35204
Modified Files:
        gdk/gdk_bat.c
Branch: Dec2025
Log Message:

Only use per row insert for "external" atoms.


diffs (21 lines):

diff --git a/gdk/gdk_bat.c b/gdk/gdk_bat.c
--- a/gdk/gdk_bat.c
+++ b/gdk/gdk_bat.c
@@ -789,7 +789,7 @@ COLcopy2(BAT *b, int tt, bool writable, 
                        bn->batCapacity = (BUN) (bn->theap->size >> bn->tshift);
                else
                        bn->batCapacity = 0;
-       } else if (tt != TYPE_void || ATOMextern(tt)) {
+       } else if (ATOMextern(tt)) {
                /* case (4): one-by-one BUN insert (really slow) */
                QryCtx *qry_ctx = MT_thread_get_qry_ctx();
 
@@ -802,7 +802,7 @@ COLcopy2(BAT *b, int tt, bool writable, 
                }
                TIMEOUT_CHECK(qry_ctx, 
GOTO_LABEL_TIMEOUT_HANDLER(bunins_failed, qry_ctx));
                bn->theap->dirty |= bi.count > 0;
-       } else if (tt != TYPE_void && bi.type == TYPE_void) {
+       } else if (bi.type == TYPE_void) {
                /* case (4): optimized for unary void
                 * materialization */
                oid cur = bi.tseq, *dst = (oid *) Tloc(bn, 0);
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to