Changeset: f08874c1d599 for monetdb-java
URL: https://dev.monetdb.org/hg/monetdb-java/rev/f08874c1d599
Modified Files:
src/test/java/JDBC_API_Tester.java
src/test/java/org/monetdb/jdbc/ApiTests.java
Branch: default
Log Message:
Convert Test_PSlargeresponse() -> ApiTests#testPreparedLargeResponse()
diffs (66 lines):
diff --git a/src/test/java/JDBC_API_Tester.java
b/src/test/java/JDBC_API_Tester.java
--- a/src/test/java/JDBC_API_Tester.java
+++ b/src/test/java/JDBC_API_Tester.java
@@ -1024,36 +1024,6 @@ public final class JDBC_API_Tester exten
}
@Test
- public void Test_PSlargeresponse() {
- sb.setLength(0); // clear the output log buffer
-
- PreparedStatement pstmt = null;
- try {
- sb.append("1. DatabaseMetadata environment retrieval...
");
-
- // retrieve this to simulate a bug report
- con.getMetaData().getURL();
- // There used to be a test "if
(conURL.startsWith(dbmdURL))" here
- // but with the new URLs that is too simplistic.
- sb.append("oke").append("\n");
-
- pstmt = con.prepareStatement("select * from columns");
- sb.append("2. empty call...");
- // should succeed (no arguments given)
- pstmt.execute();
- sb.append(" passed\n");
- } catch (SQLException e) {
- sb.append("FAILED:
").append(e.getMessage()).append("\n");
- } finally {
- closeStmtResSet(pstmt, null);
- }
-
- compareExpectedOutput("Test_PSlargeresponse",
- "1. DatabaseMetadata environment retrieval... oke\n" +
- "2. empty call... passed\n");
- }
-
- @Test
public void Test_PSsomeamount() {
sb.setLength(0); // clear the output log buffer
diff --git a/src/test/java/org/monetdb/jdbc/ApiTests.java
b/src/test/java/org/monetdb/jdbc/ApiTests.java
--- a/src/test/java/org/monetdb/jdbc/ApiTests.java
+++ b/src/test/java/org/monetdb/jdbc/ApiTests.java
@@ -1224,4 +1224,22 @@ public class ApiTests {
"result #" + i + " is wrong"
);
}
+
+ @Test
+ public void testPreparedLargeResponse() throws SQLException {
+ // retrieve this to simulate a bug report
+ String url = conn.getMetaData().getURL();
+
+ try (PreparedStatement ps = conn.prepareStatement("SELECT *
FROM sys.columns")) {
+ ps.execute();
+ // The original test just ran execute.
+ // Maybe we should actually retrieve the data as well
+ int count = 0;
+ try (ResultSet rs = ps.executeQuery()) {
+ while (rs.next())
+ count++;
+ }
+ assertNotEquals(0, count); // stop complaints about
neccessary loop
+ }
+ }
}
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]
