Very well, will do as ya say, dear Sirs :-)
-----Ursprüngliche Nachricht----- Von: Florent Guillaume (JIRA) [mailto:[email protected]] Gesendet: Mittwoch, 1. Juli 2009 12:29 An: [email protected] Betreff: [jira] Issue Comment Edited: (CMIS-20) JCR Implementation: open session at constructor [ https://issues.apache.org/jira/browse/CMIS-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725990#action_12725990 ] Florent Guillaume edited comment on CMIS-20 at 7/1/09 3:27 AM: --------------------------------------------------------------- Thanks from me as well Michael. Another formatting remark: please use an IDE filter that strips trailing whitespace (Eclipse has them as "Save Actions"). The following part of your patch is a telltale :-) > - } > + } Finally, and probably most important, any patch should come with unit tests... was (Author: fguillaume): Thanks from me as well Michael. Another formatting remark: please use an IDE filter that strips trailing whitespace (Eclipse has them as "Save Actions"). The following part of your patch is a telltale :-) - } + } Finally, and probably most important, any patch should come with unit tests... > JCR Implementation: open session at constructor > ----------------------------------------------- > > Key: CMIS-20 > URL: https://issues.apache.org/jira/browse/CMIS-20 > Project: Chemistry > Issue Type: Improvement > Components: jcr > Reporter: Michael Mertins > Attachments: patch.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > The JcrRepository.java could be improved by passing session credentials and > opening the session in the constructor. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
