Hi, you are right. getTypes(typeid,..) speaks for a result that includes the type with typeid. I have to remove the type in services.
Chears Florian -----Ursprüngliche Nachricht----- Von: Florent Guillaume [mailto:[email protected]] Gesendet: Mittwoch, 2. Dezember 2009 12:14 An: chemistry-dev Betreff: Re: TODO in SimpleTypeManager with spec 1 clear now Hi, Yes the spec is now clear that getTypeChildren and getTypeDescendants never return the type itself, just children at various depth. I'll make sure the clients/servers behave well. However in the Java API I find this not very useful. I try to provide in the API the best user experience possible, and at the moment I have two methods: Collection<Type> getTypes(String typeId); Collection<Type> getTypes(String typeId, int depth, boolean returnPropertyDefinitions); I think a Java programmer seeing these method signatures would expect to see the type itself returned along its children. What do you think? Florent On Thu, Nov 12, 2009 at 4:36 PM, Florian Roth <[email protected]> wrote: > Hi, > > In my opinion the //TODO: in SimpleTypeManager is clear now with spec 1.0 > getTypes(typeId,-1,.) returns all descendants without Type=typeId > For me I changed TestSimpleRepository getTypes() and uncommented in > SimpleTypeManager. What do you think? I did It like that also for > JcrTypeManager. > > > //if (depth < 0) { > // list.add(types.get(typeId)); > //} > > Chears > > frh > > > in-integrierte informationssysteme GmbH > Am Seerhein 8 . 78467 Konstanz > http://www.in-gmbh.de/ . mailto:[email protected] > > Telefon: +49 7531 8145-0 > Telefax: +49 7531 8145-81 > > > Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte > Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail > irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und > vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte > Weitergabe dieser Mail sind nicht gestattet. > This e-mail may contain confidential and/or privileged information. If you > are not the intended recipient (or have received this e-mail in error) please > notify the sender immediately and destroy this e-mail. Any unauthorised > copying, disclosure or distribution of the material in this e-mail is > strictly forbidden. > > Sitz der Gesellschaft: Konstanz . Amtsgericht Freiburg i.B. . Registernummer: > HRB 380976 . Geschäftsführer: Siegfried Wagner > > > > -- Florent Guillaume, Director of R&D, Nuxeo Open Source, Java EE based, Enterprise Content Management (ECM) http://www.nuxeo.com http://www.nuxeo.org +33 1 40 33 79 87
