On Wed, 19 Jan 2011, Jeff Potts wrote:
You can find the main release candidate artifacts (for distribution at apache.org/dist) at: http://people.apache.org/~jpotts/chemistry/cmislib/0.4/dist

I've a concerns about the .egg file:
* It contains the tests, should it?
* It doesn't have the LICENSE or NOTICE file in it. It just has a single
  License line in EGG-INFO/PKG-INFO, and I'm not sure that's enough.
  See [1] [2] [3] which all seem to indicate it's needed

Also, the md5 and sha files don't seem to be in the normal form. I'd expect to see md5sum / sha1sum style output like:
        65d0d6df6162c266ea4eaaf5b88dd00e  cmislib-0.4.tar.gz
but the files only have the hash, not the file name. It's only a minor niggle, but it does make it easier to verify, so I'd suggest the build is tweaked to do that going forward.

For the gpg signings, can you add your public key to
   https://svn.apache.org/repos/asf/incubator/chemistry/opencmis/trunk/KEYS
so it can be easily checked? Also, that file should maybe be moved to the root of the chemistry svn, as it isn't opencmis specific. Once you've updated the copy in svn, you also need to copy it to the one in dist:
    http://www.apache.org/dist/incubator/chemistry/KEYS

Alas I'm therefore -1, but the steps to be done befor a new release are:
* Exclude the tests from the egg
* Embed the license and notice files in the egg (I guess probably in
  the EGG-INFO directory)
* Add your gpg key to the KEYS file

And the nice-to-haves are:
* Move the KEYS file to the root of svn
* Tweak the md5/sha1 format

Nick

[1] http://www.apache.org/dev/apply-license.html#new
[2] 
http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200806.mbox/%[email protected]%3E
[3] https://issues.apache.org/jira/browse/JDO-386

Reply via email to