Hi,
  I think I may have found a small (more confusing than problematic) bug in
Cherokee 0.5.0.
  In cherokee/handler_error.c, there's some code that prints out the error
messages related to authentication failure and SSL requirement. The problem
is, in the case of a 401 error, both of these messages get sent out one after
the other. If I've got this right, there should be a "break;" statement
inserted immediately before line 129 (case http_upgrade_required:).

Patch begins here:

--- cherokee/handler_error.c.old        2006-03-31 17:51:58.000000000 +0100
+++ cherokee/handler_error.c    2006-03-31 17:52:12.000000000 +0100
@@ -126,6 +126,7 @@
                                         "This server could not verify that you 
are authorized to access the document "
                                         "requested.  Either you supplied the 
wrong credentials (e.g., bad password), "
                                         "or your browser doesn't understand 
how to supply the credentials required.");
+               break;
        case http_upgrade_required:
                cherokee_buffer_add_str (buffer,
                                         "The requested resource can only be 
retrieved using SSL.  The server is "



Thanks.
-- 
Phil.                         | Kitsune: Acorn RiscPC SA202 64M+6G ViewFinder
[EMAIL PROTECTED]         | Cheetah: Athlon64 3200+ A8VDeluxeV2 512M+100G
http://www.philpem.me.uk/     | Tiger: Toshiba SatPro4600 Celeron700 256M+40G
_______________________________________________
Cherokee mailing list
[email protected]
http://www.0x50.org/cgi-bin/mailman/listinfo/cherokee

Reply via email to