Mohammad DAMT wrote: > This patch incorporate a HTTP POST support for fcgi.
Great stuff! :-) > cherokee_post_walk_read (cherokee_post_t *post, cherokee_buffer_t *buf, > cuint_t *size) > > I changed the 3rd argument from "cuint_t len" to "cuint_t *size". The > size will contains the available post data we read from either memory or > file. I use DEFAULT_READ_SIZE to replace the len argument. is it ok? Ummm.. but you could access it just reading buf->len, isn't it? > Also what is the correct return value of the cherokee_post_walk_read > and cherokee_post_walk_fd? ret_ok: if no more post data to be read > (all post data has been read) ret_eagain: there are still more data > to be consumed, please read again. > > is that correct? Yesterday I fixed a problem in that code, maybe you have some doubts because the weird behaviour it had due to the bug: ret_ok - It is finished, everything is sent ret_eagain - Work in progress, call the function again ret_error - Something bad happened I haven't tested the patch. I'm currently really busy with the work and the redesign of the configuration entries we are working on (the directory, extension and request stuff) but I want to test it soon in order to provide you a better feedback. Great job Mohammad! ;-) -- Greetings, alo. _______________________________________________ Cherokee mailing list [email protected] http://www.alobbs.com/cgi-bin/mailman/listinfo/cherokee
