From: Alan Post <[email protected]> Subject: Re: [Chicken-hackers] [PATCH] add input- and output port types specifiers Date: Thu, 29 Sep 2011 06:21:22 -0600
> On Thu, Sep 29, 2011 at 03:46:41AM -0400, Felix wrote: >> The attached patch introduces separate type-specifiers for input- and >> output-ports. The old "port" type is still available but only >> abbreviates "(or input-port output-port)". types.db has been >> changed accordingly and is thus not compatible to old chickens >> (so needs bootstrap). >> >> >> cheers, >> felix > > Some of this was eyeball glaze for me: I had trouble following long > lines and just skipped over them. I did spot one typo. > >> commit aa5ad07f1cf2c0754be6af26e6a937935e0f198b >> Author: felix <[email protected]> >> Date: Thu Sep 29 09:11:18 2011 +0200 >> >> - added distinguished types for input and output ports >> - old "port" type abbreviates "(or input-port output-port)" >> - small optimization in over-all-instantiations >> - removed commented out obsolete type-check generator code >> - updated types.db to use new port types >> >> diff --git a/manual/Types b/manual/Types >> index 710a17b..e45f4c2 100644 >> --- a/manual/Types >> +++ b/manual/Types >> @@ -127,7 +127,7 @@ or {{:}} should follow the syntax given below: >> <tr><td>{{pair}}</td><td>pair</td></tr> >> <tr><td>{{pointer-vector}}</td><td>vector or native pointers</td></tr> >> <tr><td>{{pointer}}</td><td>native pointer</td></tr> >> -<tr><td>{{port}}</td><td>input- or output-port</td></tr> >> +<tr><td>{{inputport}} {{output-port}}</td><td>input- or >> output-port</td></tr> >> <tr><td>{{procedure}}</td><td>unspecific procedure</td></tr> >> <tr><td>{{string}}</td><td>string</td></tr> >> <tr><td>{{symbol}}</td><td>symbol</td></tr> > > Should the '+' line rather be (adding a '-')?: > >> +<tr><td>{{input-port}} {{output-port}}</td><td>input- or >> output-port</td></tr> Yep. I'll make a new one. I'm getting used to it, so I can produce another broken patch in no time. cheers, felix _______________________________________________ Chicken-hackers mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/chicken-hackers
