Hi all, Found by Vasilij, it's a pretty obscure bug: If you install an egg with a different name than another egg which is already installed, and both eggs install a target file of the same name, chicken-install will refuse to clobber the files.
So far, so good. But chicken-install will refuse to even _build_, which means that chicken-install -n will give an error even though it would never install in the first place. The fix by Vasilij is correct; just move the check to just before running the install script instead of doing it before building. Attached is a signed-off copy. Cheers, Peter
From 49edb4f1a692999c904980db5ab1e25a7d6275c4 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann <[email protected]> Date: Sat, 13 Apr 2019 18:15:15 +0200 Subject: [PATCH] Check for installed files iff installing them Signed-off-by: Peter Bex <[email protected]> --- chicken-install.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chicken-install.scm b/chicken-install.scm index 91af7ddf..7a70227d 100644 --- a/chicken-install.scm +++ b/chicken-install.scm @@ -824,7 +824,6 @@ ver platform 'host))) - (check-installed-files name info) (let ((bscript (make-pathname dir name (build-script-extension 'host platform))) (iscript (make-pathname dir name @@ -843,6 +842,7 @@ (print "building " name) (run-script dir bscript platform) (unless (if (member name requested-eggs) no-install no-install-dependencies) + (check-installed-files name info) (print " installing " name) (run-script dir iscript platform sudo: sudo-install)) (when (and (member name requested-eggs) -- 2.11.0
signature.asc
Description: PGP signature
_______________________________________________ Chicken-hackers mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/chicken-hackers
