> On May 21, 2020, at 5:44 AM, Peter Bex <[email protected]> wrote: > > More interestingly, it seems that define-record-printer either doesn't > even work, or we're using it wrong somehow: > > No clue why this doesn't work. I checked, in CHICKEN 4 this worked, > so I think we broke this somewhere during our massive CHICKEN 5 changes. > I'm not sure it's worth fixing this, considering define-record-printer is > obsolete anyway. Presumably nobody is using it, or this would've been > reported already? > > Cheers, > Peter > <0003-Use-set-record-printer-instead-of-define-record-prin.patch>
Hey Peter, I might be misunderstanding, but quite a few Chicken 5 eggs still use define-record-printer, and it seems to work fine in Chicken 5.1.0 and 5.2.0. I’d be amenable to replacing this with set-record-printer! in my eggs for Chicken 5 (I was unaware this was deprecated), but you’d have to hunt down a lot of references if you want to remove it. For example, a quick check of sql-de-lite looks ok: > ag define-record-printer sql-de-lite.scm 182:(define-record-printer (sqlite-database db port) 216:(define-record-printer (sqlite-statement s p) > ~/local/chicken/5.2.0/bin/csi CHICKEN (c) 2008-2020, The CHICKEN Team (c) 2000-2007, Felix L. Winkelmann Version 5.2.0 (rev 317468e4) macosx-unix-clang-x86-64 [ 64bit dload ptables ] Type ,? for help. ; loading /Users/jim/.csirc ... #;1> (import sql-de-lite) ; loading /Users/jim/local/chicken/5.2.0/lib/chicken/11/sql-de-lite.import.so ... ; loading /Users/jim/local/chicken/5.2.0/lib/chicken/11/sql-de-lite.so ... […] #;2> (open-database "a.db") #<sqlite-database #<pointer 0x7fe936701670> on "a.db”>
